confused

22 views
Skip to first unread message

Bigos

unread,
Jul 11, 2017, 2:52:05 PM7/11/17
to Ruby on Rails: Talk
    output.each{|o| o.map!{|i| {:space_nickname => i.space.nickname, :nickname => i.nickname, :condition_number => i.condition,
                                :condition => report_config.slider_order[i.condition][1],
                                :full_note => "#{i.full_note.strip} \n #{i.photos.select{|p| !p.caption.blank? }.map{|p|
                                  "[Photo #{photo_number_for(report.photo_numbers.hash, p)}] #{p.caption}"
                                }.compact.join("\n")}".strip,
                                :description => i.description, :trade => i.trade, :flagged => !i.require_maintenance.blank? }}}
    output.reject(&:empty?)

My coworker says it is valid Ruby, but Emacs highliting gets mangled. Does anybody know where I should report issues with that? I could only find an svn repo for that particular plugin for Emacs. 

Rob Biedenharn

unread,
Jul 11, 2017, 3:29:42 PM7/11/17
to rubyonra...@googlegroups.com
Where is the closing quote for the line that starts with:
:full_note => "
If you have "nested" quotes inside interpolations, perhaps you need to use %{} instead of ""

Or, perhaps even better, don't try to be so clever and compact:

output.each {|o|
o.map! {|i|
full_note = [i.full_note.strip]
i.photos.each do |photo|
next if photo.caption.blank?
full_note << "[Photo #{photo_number_for(report.photo_numbers.hash, photo)}] #{photo.caption}"
end
{
:space_nickname => i.space.nickname,
:nickname => i.nickname,
:condition_number => i.condition,
:condition => report_config.slider_order[i.condition][1],
:full_note => full_note.join("\n").strip,
:description => i.description,
:trade => i.trade,
:flagged => !i.require_maintenance.blank?
}
}
}
output.reject(&:empty?)

-Rob

Reply all
Reply to author
Forward
0 new messages