Please apply [6343]

5 views
Skip to first unread message

François Beausoleil

unread,
Apr 22, 2007, 10:48:00 PM4/22/07
to rubyonra...@googlegroups.com
Hi all,

[6343] http://dev.rubyonrails.org/changeset/6343

allows #link_to to correctly parse and generate nested hash parameters:

link_to("link", :a => {:b => "c"}) generates a different URL on trunk/
than on 1.2-stable:

trunk: <a href="?a[b]=c">link</>
1.2-stable: <a href="?a=bc">link</>

Recent discussion by me on the subject:
http://groups.google.com/group/rubyonrails-core/browse_thread/thread/612171b2df5e5c81/45010f92f8fce4e2?lnk=gst&q=rails+core+nested+hash+parameters&rnum=1&hl=en#45010f92f8fce4e2

When I tested, 6343 applied cleanly to 1.2, except for the CHANGELOG.

Thanks !
--
François Beausoleil
http://blog.teksol.info/
http://piston.rubyforge.org/

François Beausoleil

unread,
Oct 11, 2007, 1:24:43 AM10/11/07
to rubyonra...@googlegroups.com
Hi all,

2007/4/22, François Beausoleil <francois....@gmail.com>:


> [6343] http://dev.rubyonrails.org/changeset/6343
>
> allows #link_to to correctly parse and generate nested hash parameters:
>
> link_to("link", :a => {:b => "c"}) generates a different URL on trunk/
> than on 1.2-stable:
>
> trunk: <a href="?a[b]=c">link</>
> 1.2-stable: <a href="?a=bc">link</>

Diego Algorta Casamayou just patched 1-2-stable:
http://dev.rubyonrails.org/ticket/7047

I applied the patch to 7833 and ran the tests successfully. So, here's my +1.

Bye !

Jeremy Kemper

unread,
Oct 11, 2007, 1:57:26 AM10/11/07
to rubyonra...@googlegroups.com
On 10/10/07, François Beausoleil <francois....@gmail.com> wrote:
> Diego Algorta Casamayou just patched 1-2-stable:
> http://dev.rubyonrails.org/ticket/7047
>
> I applied the patch to 7833 and ran the tests successfully. So, here's my +1.

Done. Nice work, Diego!

jeremy

diegal

unread,
Oct 11, 2007, 2:41:45 AM10/11/07
to Ruby on Rails: Core
On Oct 11, 3:57 am, "Jeremy Kemper" <jer...@bitsweat.net> wrote:

> On 10/10/07, François Beausoleil <francois.beausol...@gmail.com> wrote:
>
> > Diego Algorta Casamayou just patched 1-2-stable:
> >http://dev.rubyonrails.org/ticket/7047
>
> > I applied the patch to 7833 and ran the tests successfully. So, here's my +1.
>
> Done. Nice work, Diego!
>
> jeremy

Wow! that's fast! :-D
Cool.

Diego
--
http://www.oboxodo.com - http://diego.algorta.net/

Reply all
Reply to author
Forward
0 new messages