Support for OpenID::SETUP_NEEDED in open_id_authentication plugin

[Jacek Becela]

Hello,

This should interest anyone using open_id_authentication plugin. There
is a bug in current version which causes that
authenticate_with_open_id method doesn't yield the result but silently
returns when server returns with OpenID::SETUP_NEEDED response.

This patch ( http://dev.rubyonrails.org/ticket/10231 ) resolves the
problem.

--
Jacek

[Nicola Piccinini]

I believe that SETUP_NEEDED should be considered in conjunction with
immediate mode, I've added a second "proof of concept" patch to the
ticket.

By the way, there could be a problem with the open_id_authentication
plugin and PostgreSQL adapter, I suppose.
Please take a read to
http://groups.google.com/group/rubyonrails-talk/tree/browse_frm/thread/7d2cd4ffaa517c78/dc7dd20033011438?rnum=1&q=openid&_done=%2Fgroup%2Frubyonrails-talk%2Fbrowse_frm%2Fthread%2F7d2cd4ffaa517c78%2Fdc7dd20033011438%3Flnk%3Dgst%26q%3Dopenid%26#doc_dc7dd20033011438
thanks,

Nicola

[Jacek Becela]

On Nov 27, 10:16 am, Nicola Piccinini <piccin...@gmail.com> wrote:
> I believe that SETUP_NEEDED should be considered in conjunction with
> immediate mode, I've added a second "proof of concept" patch to the
> ticket.
>
> By the way, there could be a problem with theopen_id_authentication
> plugin and PostgreSQL adapter, I suppose.

> Please take a read tohttp://groups.google.com/group/rubyonrails-talk/tree/browse_frm/threa...
> thanks,
>
> Nicola

I've added some test to your patch.

Regarding the PostgreSQL issue, it seems (I didn't check it though)
that underlying ruby-openid returns non-utf-8 characters as a secret.
Did you try to change OpenID provider (from myopenid.com to something
else)?

Regards,

--
Jacek

[Nicola Piccinini]

> I've added some test to your patch.

great

> Regarding the PostgreSQL issue, it seems (I didn't check it though)
> that underlying ruby-openid returns non-utf-8 characters as a secret.
> Did you try to change OpenID provider (from myopenid.com to something
> else)?

Cause of this problem I'm going with MySQL, anyway I've done a quick
check and I've the same result with getopenid.com.

I'm puzzled, I've no idea where the problem is:
* my postgresql/system configuration,
* openid provider,
* ruby-openid,
* openid_authentication_plugin,
* my RoR code
Suggestions?

Thanks,
Nicola