Pretty Location is not pretty

[uys...@gmail.com]

It i have a model call EmailTemplate and I use column thumbnail as image column. I use pretty_location plugin.

Image should store under path /email_template/thumnial But instead it store /emailtemplate/thumnial which is look bad. 

[Janko Marohnić]

Thank you for the feedback. You're right, I don't know why I made it not use underscores.

I'm looking for the right way to fix this. I don't want to change the default, even for Shrine 3.0, as this would mean the directory would change for some people. I will probably add a plugin option to use underscores.

Kind regards,
Janko

On 9 Sep 2019, 17:02 +0200, uys...@gmail.com, wrote:

It i have a model call EmailTemplate and I use column thumbnail as image column. I use pretty_location plugin.

Image should store under path /email_template/thumnial But instead it store /emailtemplate/thumnial which is look bad. 

--
You received this message because you are subscribed to the Google Groups "Shrine" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ruby-shrine...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ruby-shrine/ede1025e-8894-4602-95ec-7eca61bc5ff7%40googlegroups.com.

[uys...@gmail.com]

I have create a pull request https://github.com/shrinerb/shrine/pull/412

Hope it merge soon

On Tuesday, September 17, 2019 at 7:43:06 PM UTC+7, Janko Marohnić wrote:

Thank you for the feedback. You're right, I don't know why I made it not use underscores.

I'm looking for the right way to fix this. I don't want to change the default, even for Shrine 3.0, as this would mean the directory would change for some people. I will probably add a plugin option to use underscores.

Kind regards,
Janko

On 9 Sep 2019, 17:02 +0200, uys...@gmail.com, wrote:

It i have a model call EmailTemplate and I use column thumbnail as image column. I use pretty_location plugin.

Image should store under path /email_template/thumnial But instead it store /emailtemplate/thumnial which is look bad. 

--
You received this message because you are subscribed to the Google Groups "Shrine" group.

To unsubscribe from this group and stop receiving emails from it, send an email to ruby-...@googlegroups.com.