[CVE-2020-8165] Potentially unintended unmarshalling of user-provided objects in MemCacheStore and RedisCacheStore

1775 views
Skip to first unread message

Aaron Patterson

unread,
May 18, 2020, 11:56:47 AM5/18/20
to ruby-sec...@googlegroups.com, rubyonrail...@googlegroups.com
Potentially unintended unmarshalling of user-provided objects in MemCacheStore and RedisCacheStore

There is potentially unexpected behaviour in the MemCacheStore and RedisCacheStore where, when
untrusted user input is written to the cache store using the `raw: true` parameter, re-reading the result
from the cache can evaluate the user input as a Marshalled object instead of plain text. Vulnerable code looks like:

```
data = cache.fetch("demo", raw: true) { untrusted_string }
```

This vulnerability has been assigned the CVE identifier CVE-2020-8165.


Versions Affected: rails < 5.2.5, rails < 6.0.4
Not affected: Applications not using MemCacheStoer or RedisCacheStore. Applications that do not use the `raw` option when storing untrusted user input.
Fixed Versions: rails >= 5.2.4.3, rails >= 6.0.3.1

Impact
------

Unmarshalling of untrusted user input can have impact up to and including RCE. At a minimum,
this vulnerability allows an attacker to inject untrusted Ruby objects into a web application.

In addition to upgrading to the latest versions of Rails, developers should ensure that whenever
they are calling `Rails.cache.fetch` they are using consistent values of the `raw` parameter for both
reading and writing, especially in the case of the RedisCacheStore which does not, prior to these changes,
detect if data was serialized using the raw option upon deserialization.

Releases
--------

The fixed releases are available on RubyGems.

Workarounds
-----------

It is recommended that application developers apply the suggested patch or upgrade to the latest release as
soon as possible. If this is not possible, we recommend ensuring that all user-provided strings cached using
the `raw` argument should be double-checked to ensure that they conform to the expected format.

Patches
-------

For developers who are not able to immediately patch their applications,
we are including the following patches for Rails 6.0.3 and Rails 5.2.4.2.

* 5-2-cache-storage.patch - Patch for 5.2 series
* 6-0-cache-storage.patch - Patch for 6.0 series


Credits
-------

Thank you to Dylan Thacker-Smith for reporting this vulnerability via our HackerOne program and providing a comprehensive set of patches.
5-2-cache-storage.patch
6-0-cache-storage.patch
Reply all
Reply to author
Forward
0 new messages