Many typo and fixs for mastering roda

24 views
Skip to first unread message

Billy Zheng

unread,
Jul 14, 2021, 2:57:05 PMJul 14
to Roda
Hi,  Jeremy.


Do you have time to check those typo issue and fix that? anyway, original author seem like no response for a long time.

anyway, i like roda, i want to make this book better.

Thank you.

Jeremy Evans

unread,
Jul 14, 2021, 3:01:50 PMJul 14
to ruby...@googlegroups.com
Billy,

Thanks for your help. Sorry, I hadn't marked that repository as being watched, so I didn't get contacted for issues and merge requests in that repository. I've started watching the repository, so I'll be more proactive about fixing issues in the future.  I'll try to review your issue this week or next week and make the appropriate changes, as well as take care of a couple merge requests that have come in in the last year.

Thanks,
Jeremy

Billy Zheng

unread,
Jul 14, 2021, 3:27:08 PMJul 14
to Roda

> as well as take care of a couple merge requests that have come in in the last year.

Yes, i thought the hash_routes plugin seem like change a lot since this book published.

and some useful convention(if i guess correct) not mention in this book too.

e.g.

1.  i guess we perfer to use r.is true { ...} over r.is { ... }, right? though, i thought both exact same behavior.
2.  except on matcher, any others matcher (e.g. is,get, post etc), if first arg is exists, must be terminal matcher, right?
3. compare r.?? "" with r.?? true, empty string match the ending /, then latter is match empty remaining path.

Anyway, those are some confusing part for me, maybe useful.

Thank you.
Reply all
Reply to author
Forward
0 new messages