ruby-gettext/gettext@479d053 [master] Merge pull request #58 from 284km/fix_warning_unused_variable

0 views
Skip to first unread message

Kouhei Sutou

unread,
May 7, 2018, 5:33:46 PM5/7/18
to ruby-gett...@googlegroups.com
Author
Kouhei Sutou <k...@cozmixng.org>
Date
2018-05-08 06:33:32 +0900 (Tue, 08 May 2018)
New Revision
479d0530d6f0703ce633e42bb336cfbd0a42fa88
Message
Merge pull request #58 from 284km/fix_warning_unused_variable

Fix warning: assigned but unused variable - sorted_entries

Patch by 284km. Thanks!!!!

284km

unread,
May 7, 2018, 5:33:47 PM5/7/18
to ruby-gett...@googlegroups.com
Author
284km <k.furu...@gmail.com>
Date
2018-05-07 18:31:52 +0900 (Mon, 07 May 2018)
New Revision
c91431eca1cf7a0496a7cebf892b6e85dc6912cd
Merge
  • Merged 479d053: Merge pull request #58 from 284km/fix_warning_unused_variable
Message
Fix warning: assigned but unused variable - sorted_entries

"sorted_entries" is a descriptive variable name, it is easy to read.
However, even if there is no local variable name, I think it is obvious to return "sorted_entries" here.
Modified files
  Modified: lib/gettext/po.rb (+3 -3)
===================================================================

...
222
223
224
225
 
226
227
 
228
229
 
230
231
232

...
222
223
224
 
225
226
 
227
228
 
229
230
231
232

@@ -222,11 +222,11 @@ module GetText
     def sort(entries)
       case @order
       when :reference, :references # :references is deprecated.
-        sorted_entries = sort_by_reference(entries)
+        sort_by_reference(entries)
       when :msgid
-        sorted_entries = sort_by_msgid(entries)
+        sort_by_msgid(entries)
       else
-        sorted_entries = entries.to_a
+        entries.to_a
       end
     end
Reply all
Reply to author
Forward
0 new messages