[ruby-core:35474] Fwd: You rogerpack2005@gmail.com are not member (ruby-core ML)
Roger Pack
account, in case it's not expected.
Cheers!
-r
---------- Forwarded message ----------
From: Roger Pack <rogerp...@gmail.com>
Date: Wed, Mar 9, 2011 at 4:12 PM
Subject: Fwd: You rogerp...@gmail.com are not member (ruby-core ML)
To: roger...@gmail.com
---------- Forwarded message ----------
From: <ruby-co...@ruby-lang.org>
Date: Wed, Mar 9, 2011 at 11:25 AM
Subject: You rogerp...@gmail.com are not member (ruby-core ML)
To: rogerp...@gmail.com
You are not a member of this mailing list <ruby...@ruby-lang.org>.
If you want to know the general guide of this list, please send an email
with the body (case-insensitive):
# guide
to the address
Note that the mail should not be encoded in base64.
Roger Pack
user, not subscribed]? Currently my updates to redmine tickets don't
get copied to ruby-core because of it, I believe...
Thanks much.
-r
Yui NARUSE
Issue #4487 has been updated by Yui NARUSE.
Status changed from Open to Assigned
Assignee set to Yusuke Endoh
----------------------------------------
Bug #4487: require_relative fails in an eval'ed file
http://redmine.ruby-lang.org/issues/4487
Author: Roger Pack
Status: Assigned
Priority: Normal
Assignee: Yusuke Endoh
Category:
Target version:
ruby -v: ruby 1.9.3dev (2011-03-04 trunk 31024) [i386-mingw32]
=begin
Hello all.
$cat eval_me1.rb
eval(File.read('eval_me2.rb'), binding, File.expand_path('./eval_me2.rb'))
$cat eval_me2.rb
require_relative 'eval_me1.rb'
$ ruby eval_me1.rb
C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `require_relative': cannot infer basepath (LoadError)
from C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `<main>'
from eval_me1.rb:1:in `eval'
from eval_me1.rb:1:in `<main>'
I suppose was assuming that if eval included a filename, then require_relative would work from within it. Perhaps I am mistaken?
Thanks!
-r
=end
Yusuke ENDOH
> $cat eval_me1.rb
> eval(File.read('eval_me2.rb'), binding, File.expand_path('./eval_me2.rb'))
> $cat eval_me2.rb
> require_relative 'eval_me1.rb'
> $ ruby eval_me1.rb
> C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `require_relative': cannot infer basepath (LoadError)
> from C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `<main>'
> from eval_me1.rb:1:in `eval'
> from eval_me1.rb:1:in `<main>'
>
> I suppose was assuming that if eval included a filename, then require_relative would work from within it. Perhaps I am mistaken?
I think your expectation is reasonable, though I personally dislike
the eval's feature to fake filepath.
The following patch makes require_relative use the given file path.
I'm afraid if I should include this patch in 1.9.3 because I can't
estimate the impact of this patch. What do you think?
diff --git a/vm_eval.c b/vm_eval.c
index 7df7f5f..3710401 100644
--- a/vm_eval.c
+++ b/vm_eval.c
@@ -1007,7 +1007,7 @@ eval_string_with_cref(VALUE self, VALUE src,
VALUE scope, NODE *cref, const char
/* make eval iseq */
th->parse_in_eval++;
th->mild_compile_error++;
- iseqval = rb_iseq_compile(src, rb_str_new2(file), INT2FIX(line));
+ iseqval = rb_iseq_compile_with_option(src, rb_str_new2(file),
rb_str_new2(file), INT2FIX(line), Qnil);
th->mild_compile_error--;
th->parse_in_eval--;
--
Yusuke Endoh <ma...@tsg.ne.jp>
Yusuke Endoh
Issue #4487 has been updated by Yusuke Endoh.
Assignee changed from Yusuke Endoh to Yukihiro Matsumoto
Related to #4352.
I need matz's judgment.
--
Yusuke Endoh <ma...@tsg.ne.jp>
----------------------------------------
Bug #4487: require_relative fails in an eval'ed file
http://redmine.ruby-lang.org/issues/4487
Author: Roger Pack
Status: Assigned
Priority: Normal
Assignee: Yukihiro Matsumoto
Category:
Target version:
ruby -v: -
=begin
Hello all.
$cat eval_me1.rb
eval(File.read('eval_me2.rb'), binding, File.expand_path('./eval_me2.rb'))
$cat eval_me2.rb
require_relative 'eval_me1.rb'
$ ruby eval_me1.rb
C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `require_relative': cannot infer basepath (LoadError)
from C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `<main>'
from eval_me1.rb:1:in `eval'
from eval_me1.rb:1:in `<main>'
I suppose was assuming that if eval included a filename, then require_relative would work from within it. Perhaps I am mistaken?
LTe (Piotr Niełacny)
Issue #4487 has been updated by LTe (Piotr Niełacny).
=begin
If in irb we can execute
(({load("file.rb")}))
why we can't
(({require_relative("file")}))
Ruby just return exception (LoadError: cannot infer basepath). Unfortunately, this is a 'lie' because ruby can recognize basepath.
=end
Bug #4487: require_relative fails in an eval'ed file
Author: rogerdpack (Roger Pack)
Status: Assigned
Priority: Normal
Assignee: matz (Yukihiro Matsumoto)
Target version:
ruby -v: -
=begin
Hello all.
$cat eval_me1.rb
eval(File.read('eval_me2.rb'), binding, File.expand_path('./eval_me2.rb'))
$cat eval_me2.rb
require_relative 'eval_me1.rb'
$ ruby eval_me1.rb
C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `require_relative': cannot infer basepath (LoadError)
from C:/dev/ruby/faster_require/spec/eval_me2.rb:1:in `<main>'
from eval_me1.rb:1:in `eval'
from eval_me1.rb:1:in `<main>'
I suppose was assuming that if eval included a filename, then require_relative would work from within it. Perhaps I am mistaken?
Thanks!
-r
=end
--
shyouhei (Shyouhei Urabe)
Issue #4487 has been updated by shyouhei (Shyouhei Urabe).
=begin
@LTe sorry, I can't get it. load loads from $LOAD_PATH, while require_relative requires from relative path. They are different.
=end
----------------------------------------
Bug #4487: require_relative fails in an eval'ed file
LTe (Piotr Niełacny)
Issue #4487 has been updated by LTe (Piotr Niełacny).
@shyouhei yes I agree but load method tries to load file from relative path. When load method can't find file in relative path it loads from $LOAD_PATH. The same can be done by require_relative (recognize path).
https://github.com/ruby/ruby/pull/139
Bug #4487: require_relative fails in an eval'ed file
shyouhei (Shyouhei Urabe)
Issue #4487 has been updated by shyouhei (Shyouhei Urabe).
=begin
Obviously it is not relative from your mind :)
Current require_relative loads relative from where the require_relative command is written. So when in IRB sessions, it fails to infer where it is beacuse the command is written in a non-file (console).
OTOH load loads from process PWD, which is possible in IRB.
So the point is, if you want require_relative to work on an IRB session, you have to define "from where require_relative should search relativeness".
=end
----------------------------------------
Bug #4487: require_relative fails in an eval'ed file
Eregon (Benoit Daloze)
Issue #4487 has been updated by Eregon (Benoit Daloze).
shyouhei (Shyouhei Urabe) wrote:
> Current require_relative loads relative from where the require_relative command is written. So when in IRB sessions, it fails to infer where it is beacuse the command is written in a non-file (console).
>
> OTOH load loads from process PWD, which is possible in IRB.
>
> So the point is, if you want require_relative to work on an IRB session, you have to define "from where require_relative should search relativeness".
Personally I'm doing `require './myfile'` which is not the most elegant, but if you don't have completion in IRB, that's shorter to type.
Otherwise, there's always the option to do `irb -I.` and use plain `require`.
Bug #4487: require_relative fails in an eval'ed file
naruse (Yui NARUSE)
Issue #4487 has been updated by naruse (Yui NARUSE).
Eregon (Benoit Daloze) wrote:
> shyouhei (Shyouhei Urabe) wrote:
> > Current require_relative loads relative from where the require_relative command is written. So when in IRB sessions, it fails to infer where it is beacuse the command is written in a non-file (console).
> >
> > OTOH load loads from process PWD, which is possible in IRB.
> >
> > So the point is, if you want require_relative to work on an IRB session, you have to define "from where require_relative should search relativeness".
>
> From the process current working directory I guess, especially since you almost always launch IRB from a terminal.
>
> Personally I'm doing `require './myfile'` which is not the most elegant, but if you don't have completion in IRB, that's shorter to type.
>
> Otherwise, there's always the option to do `irb -I.` and use plain `require`.
So it can't be acceptable.
Use require or load on such case.
Bug #4487: require_relative fails in an eval'ed file
shyouhei (Shyouhei Urabe)
Issue #4487 has been updated by shyouhei (Shyouhei Urabe).
naruse (Yui NARUSE) wrote:
> require_relative is introduced to avoid accidentally require a malicious file on the current working directory.
> So it can't be acceptable.
> Use require or load on such case.
Because you are on an IRB session and intentionally emitting require_relative (not require), I doubt the danger you say.
----------------------------------------
Bug #4487: require_relative fails in an eval'ed file
naruse (Yui NARUSE)
Issue #4487 has been updated by naruse (Yui NARUSE).
shyouhei (Shyouhei Urabe) wrote:
> naruse (Yui NARUSE) wrote:
> > require_relative is introduced to avoid accidentally require a malicious file on the current working directory.
> > So it can't be acceptable.
> > Use require or load on such case.
>
> I'm not pretty sure about this. Is there a chance for a (proposed behaviour of) require_relative to require a malicious file on the current directory?
>
> Because you are on an IRB session and intentionally emitting require_relative (not require), I doubt the danger you say.
* A user won't always use require_relative intentionally.
* There is a suitable another way: require './myfile'
With those reason, I don't think require_relative should be changed.
Bug #4487: require_relative fails in an eval'ed file
Eregon (Benoit Daloze)
Issue #4487 has been updated by Eregon (Benoit Daloze).
naruse (Yui NARUSE) wrote:
> > From the process current working directory I guess, especially since you almost always launch IRB from a terminal.
>
> So it can't be acceptable.
> Use require or load on such case.
Indeed, with this in mind I think it's not worth changing, and the actual require_relative behavior is clearer (relative to "this file" directory, if there is no accurate "this file", just #raise).
Bug #4487: require_relative fails in an eval'ed file
ko1 (Koichi Sasada)
Issue #4487 has been updated by ko1 (Koichi Sasada).
Assignee changed from matz (Yukihiro Matsumoto) to mame (Yusuke Endoh)
mame-san, please ask matz.
Bug #4487: require_relative fails in an eval'ed file
Author: rogerdpack (Roger Pack)
Status: Assigned
Priority: Normal
mame (Yusuke Endoh)
Issue #4487 has been updated by mame (Yusuke Endoh).
Subject changed from require_relative fails in an eval'ed file to require_relative fails in an eval'ed file
Assignee changed from mame (Yusuke Endoh) to matz (Yukihiro Matsumoto)
Target version set to next minor
----------------------------------------
Bug #4487: require_relative fails in an eval'ed file
https://bugs.ruby-lang.org/issues/4487#change-35777
Author: rogerdpack (Roger Pack)
Status: Assigned
Priority: Normal
Category:
Conrad.Irwin (Conrad Irwin)
Issue #4487 has been updated by Conrad.Irwin (Conrad Irwin).
This bug also affects pry: https://github.com/pry/pry/issues/880. Our use-case is slightly different because we are doing TOPLEVEL_BINDING.eval("some code", "/absolute/path.rb").
I think that when an absolute path is set in eval, then require_relative should use it.
----------------------------------------
Bug #4487: require_relative fails in an eval'ed file
https://bugs.ruby-lang.org/issues/4487#change-37839