REXML in 1.8.6 p114

2 views

Skip to first unread message

Michael Klishin

unread,

Mar 27, 2008, 5:11:02 PM3/27/08

to ruby...@ruby-lang.org

In REXML in 1.8.6 p114 call site to
REXML::Formatters::Transitive#initialize in REXML::Document#write uses
old method signature (thus wrong arity) on line 188. Simple script to
reproduce, pulled from Rubinius' spec suite:

http://pastie.org/171683

In ruby 1.8 branch I see REXML completely reorganized so there's
basically no way to submit a patch until you know where 1.8 is headed.

Could someone shed some light on it?

--
MK

http://novemberain.com

Sean E. Russell

unread,

Apr 10, 2008, 9:32:21 PM4/10/08

to ruby...@ruby-lang.org

On Thursday 27 March 2008, Michael Klishin wrote:
> In REXML in 1.8.6 p114 call site to
> REXML::Formatters::Transitive#initialize in REXML::Document#write uses
> old method signature (thus wrong arity) on line 188. Simple script to

...

> Could someone shed some light on it?

Yes. A patch fix supplied by a contributor was applied that introduced this
regression. There was no unit test that would have caught this, so it ended
up being propagated back to the Ruby trunk.

This has been fixed in the REXML repository, and a unit test has been
introduced to catch any future regressions (of this feature). It hasn't yet
made it into the Ruby repository, but will soon.

Of course, special dispensation will need to be gained for code freezes.

Reply all

Reply to author

Forward

0 new messages