Issue 260 in rtm-ros-robotics: run_depend on pr2_controllers fails in Groovy

[rtm-ros-...@googlecode.com]

Status: New
Owner: kei.ok...@gmail.com
CC: iisaac.s...@gmail.com
Labels: Type-Defect Priority-Medium

New issue 260 by gm130s: run_depend on pr2_controllers fails in Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

Starting since
http://code.google.com/p/rtm-ros-robotics/source/detail?spec=svn5905&r=5903
this commit, rosdep (via bloom) fails saying pr2_controllers is not found.


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[rtm-ros-...@googlecode.com]

Comment #1 on issue 260 by kei.ok...@gmail.com: run_depend on

pr2_controllers fails in Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

See the diff, we use sed to remove pr2_controllers from *_depend if
ROS_ROOT is /opt/ros/groovy...., and make sure if this works on your local
computer.
So what's difference on bloom? ROS_ROOT? or sed is missing?

https://code.google.com/p/rtm-ros-robotics/source/diff?spec=svn5905&r=5903&format=side&path=/trunk/rtmros_common/hrpsys_ros_bridge/catkin.cmake&old_path=/trunk/rtmros_common/hrpsys_ros_bridge/catkin.cmake&old=5592

[rtm-ros-...@googlecode.com]

Comment #2 on issue 260 by kei.ok...@gmail.com: run_depend on

pr2_controllers fails in Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

Does bloom run rosdep, before make command (, which runs sed to modify
package.xml to remove pr2_controllers? )?? if so, we need to create patch
for rtmros_common-release,
I'm not sure how it works, but there are patch directory and bloom will
apply patch files from this directory:
https://github.com/start-jsk/rtmros_common-release/tree/patches/debian/groovy/hrpsys_ros_bridge

http://wiki.ros.org/bloom/Tutorials/ReleaseThirdParty#Porting_patches_from_one_rosdistro_to_another
says that just to copy patch files will works?

[rtm-ros-...@googlecode.com]

Updates:
Status: Accepted

Comment #3 on issue 260 by gm130s: run_depend on pr2_controllers fails in
Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

> Does bloom run rosdep, before make command ??

I suspect bloom does not run any *make commands; it resolve depndency and
then create "debian" files/branches per distribution and building work is
delegated to buildfarm?

Example of debian. debian/groovy/hrpsys_ros_bridge

https://github.com/start-jsk/rtmros_common-release/tree/debian/groovy/hrpsys_ros_bridge

> if so, we need to create patch for rtmros_common-release, I'm not sure
> how it works, but there are patch directory and bloom will apply patch
> files from this directory:

I'm not sure either how this works; it may or may not be what we want.

Another workaround is to branch Groovy and Hydro? To make it a bit easier
do we want to move rtmros_common to github?

[rtm-ros-...@googlecode.com]

Comment #4 on issue 260 by kei.ok...@gmail.com: run_depend on

pr2_controllers fails in Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

branch is not good solution unless someone take responsibility to always
keep watching source code and copy code commited to hydro to groovy and
copy code commited to groovy to hydro.

http://wiki.ros.org/bloom/Tutorials/ReleaseThirdParty#Porting_patches_from_one_rosdistro_to_another,
should
work.

[rtm-ros-...@googlecode.com]

Comment #5 on issue 260 by kei.ok...@gmail.com: run_depend on

pr2_controllers fails in Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

Humm, you're right patches/release/groovy/hrpsys_ros_bridge does not work
for this situation..

so what I did is :
1) create /home/k-okada/ros/rosdistro/rosdep/hrpsys_groovy.yaml file that
contains:
pr2_controllers:
ubuntu: []
2) add `yaml file:///home/k-okada/ros/rosdistro/rosdep/hrpsys_groovy.yaml`
line in /etc/ros/rosdep/sources.list.d/20-default.list
3) run git-bloom-release groovy
4) git checkout release/groovy/hrpsys_ros_bridge
5) edit package.xml and comment out pr2_controllers
6) git commit
7) git push --all && git push --tags

hope this does not break existing setup..

[rtm-ros-...@googlecode.com]

Updates:
Status: Started

Comment #6 on issue 260 by gm130s: run_depend on pr2_controllers fails in
Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

On Groovy with r6941, I'm trying the suggestion
https://code.google.com/p/rtm-ros-robotics/issues/detail?id=260#c5 and
still get the same error:

$ git clone https://github.com/start-jsk/rtmros_common-release.git
$ cd rtmros_common-release/
$ git checkout release/groovy/hrpsys_ros_bridge
$ git-bloom-release groovy
:
sensor_msgs => ['ros-groovy-sensor-msgs']
pr2_controllers => []
tf => ['ros-groovy-tf']
Build and Build Tool Dependencies:
:
pr2_controllers => []
mk => ['ros-groovy-mk']
:
==> In place processing templates in 'debian' folder.
Expanding 'debian/changelog.em' -> 'debian/changelog'
Expanding 'debian/gbp.conf.em' -> 'debian/gbp.conf'
Expanding 'debian/rules.em' -> 'debian/rules'
Expanding 'debian/control.em' -> 'debian/control'
Creating tag: debian/ros-groovy-hrpsys-ros-bridge_1.0.6-0_quantal
####
#### Successfully generated 'quantal' debian for
package 'hrpsys_ros_bridge' at version '1.0.6-0'
####

```
From
file:///home/n130s/data/Dropbox/ROS/hydro_raring/catkinws/tmp/rtmros_common-release
* branch debian/groovy/hrpsys_ros_bridge -> FETCH_HEAD
It looks like git-am is in progress. Cannot rebase.

```
Traceback (most recent call last):
File "/usr/bin/git-bloom-release", line 9, in <module>

load_entry_point('bloom==0.4.9', 'console_scripts', 'git-bloom-release')()
File "/usr/lib/pymodules/python2.7/bloom/commands/git/release.py",
line 343, in main
git_clone.commit()
File "/usr/lib/pymodules/python2.7/bloom/git.py", line 133, in commit
execute_command(cmd)
File "/usr/lib/pymodules/python2.7/bloom/util.py", line 421, in
execute_command
raise CalledProcessError(result, cmd)
CalledProcessError: Command 'git pull --rebase origin
debian/groovy/hrpsys_ros_bridge' returned non-zero exit status 1

[rtm-ros-...@googlecode.com]

Comment #7 on issue 260 by gm130s: run_depend on pr2_controllers fails in
Groovy
http://code.google.com/p/rtm-ros-robotics/issues/detail?id=260

Moved to https://github.com/start-jsk/rtmros_common/issues/258
(now I don't see any option textfields so that I can't change ticket status)