Many enhancements

[James Nylen]

First of all, let me say that I really like rtgui. It is simple and
clean from a design perspective, and already very nice to use.

However, there are some features I feel it's missing. So I've
undertaken the task of going through the rtGui code as a personal
project, and in the process of adding new features, I'm simplifying
and cleaning up the code to help me get a feel for how it works. For
example, the function get_tracker_list() now looks like this in my
working copy:

// Get list of trackers associated with torrent...
function get_tracker_list($hash) {
return rtorrent_multicall('t', array($hash, ''), array(
'get_group',
'get_id',
'get_min_interval',
'get_normal_interval',
'get_scrape_complete',
'get_scrape_downloaded',
'get_scrape_time_last',
'get_type',
'get_url',
'is_enabled',
'is_open'
));
}

My ultimate goal is to move more of the logic to the browser/
Javascript, which will eliminate page refreshes and make sorting and
filtering instantaneous. I also plan to add a text box to filter
torrents based on their names in real-time (a very nice feature that
Transmission has). I'm almost to the point where these things are
working pretty well.

Simon, if you are interested in these changes, I'd be glad to work out
a way of getting them implemented with you when I get everything
finished. But I should warn you - I've changed a LOT of the code.

James

[simon]

Hi James

Well, it sounds good and of course I'm not against any enhancements.

But for my own use, I've tried to keep the client (browser) end as
lightweight as possible - I often use rtGui from my mobile phone, TV,
EeePC etc and am aware that the more Javascript stuff running, the
slower it goes. That's why I like the server to do more of the work.

I haven't been giving rtGui the attention it needs recently - I just
haven't had the time. But I'm still planning on releasing new
versions. One thing I did want to implement was a template system so
that it would be easy to change the layout (eg a 'small' version for
phones). Sorting/searching is also on the list....

-Simon

[elartista0]

Hello.
I have installed this great app and I want first of all to thank you
about it.

I also made some changes (few) to improve the number of items shown in
the
list, modifiying the CSS file.
Maybe, it could be good to change in the next release the dependency
of CSS
styles on the main page from the submodal frame, because some changes
of
main page CSS items have affected also the appear of the submodal.

Another changes I made is the rounded values of ratio, adding the
zeroes at the
end to keep the values aligned.

Thanks a lot.
El Artista.

> > James- Ocultar texto de la cita -
>
> - Mostrar texto de la cita -

[James Nylen]

I think that keeping the CSS styles tightly coupled between the main page and the submodal frames was intentional, to avoid redundant rules.  I'd suggest adding a new class to both the dialog pages and the CSS stylesheet for your modifications.

And padding the ratio with zeroes is a good idea, I think I will go do that now :)

--
You received this message because you are subscribed to the Google Groups "rtGui" group.
To post to this group, send email to rt...@googlegroups.com.
To unsubscribe from this group, send email to rtgui+un...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/rtgui?hl=en.

[James Nylen]

Simon,

While I understand your reluctance to add a lot more Javascript to the application, I've tried (pretty successfully) to execute the minimum amount of code necessary in every step.  The only place where things seem to slow down is when using client-side sorting on low-powered devices like a phone.  On a computer, the sorting is instantaneous (until you start talking about moving DOM elements around the page, but even then, my code always performs the least possible number of moves.)  I also think that a lot of your users who only use rtGui on their computers would be interested in having an rtGui that is primarily driven by AJAX requests (or more correctly, AJAJ).

Still, I'd like to suggest a couple of enhancements for your consideration:

1) rtorrent_multicall() function - this will allow you to eliminate redundancy in the functions that need to do a "multicall" request to rTorrent.  This makes it much easier to add, remove, or reorder parameters that you want rTorrent to return.  An example of how to use it is in my first email on this thread.  This code is at http://pastebin.com/d74j552P.

2) scgi_send() function - direct communication with rTorrent's built-in scgi server.  This removes the need to set up a web server with an address dedicated to RPC calls.  Instead, you can connect to rTorrent's scgi port directly.  I think this should at least be an optional connection method.  This code is at http://pastebin.com/UxE7N7yG.

Regards,
James

[James Nylen]

Since the last email on this subject, I've made my enhanced rtGui code public on github:

http://github.com/nylen/rtgui

A couple of caveats:

* The search/filter box does not work yet.

* The configuration is perhaps a little tricky since I added a bunch of new features to support my workflow.

But it works very well for my day-to-day use.

On Feb 23, 2010 6:06 PM, "James Nylen" <jny...@gmail.com> wrote:

I think that keeping the CSS styles tightly coupled between the main page and the submodal frames was intentional, to avoid redundant rules.  I'd suggest adding a new class to both the dialog pages and the CSS stylesheet for your modifications.

And padding the ratio with zeroes is a good idea, I think I will go do that now :)

On Fri, Feb 19, 2010 at 8:42 AM, elartista0 <elart...@gmail.com> wrote:
>
> Hello.

> I have ins...