Current code style?

2 views
Skip to first unread message

Brian Murphy

unread,
May 14, 2026, 5:15:10 PM (3 days ago) May 14
to rr-devel
The `CONTRIBUTING.md` file in the project says"
```
- [ ] Did you check your code is formatted correctly? It's easiest to run `scripts/reformat.sh` on each commit.
```
but running that script on the current master branch yields many many changes.

What's a newbie to do?  I guess you're all busy with Pernosco?  How's that going?  Does it make Rust debuggable?

-Brian

Robert O'Callahan

unread,
May 15, 2026, 7:33:50 PM (2 days ago) May 15
to Brian Murphy, rr-devel
On Fri, 15 May 2026 at 09:15, Brian Murphy <brianr...@gmail.com> wrote:
The `CONTRIBUTING.md` file in the project says"
```
- [ ] Did you check your code is formatted correctly? It's easiest to run `scripts/reformat.sh` on each commit.
```
but running that script on the current master branch yields many many changes.

Yeah.

Pernosco maintains a private branch of rr with some extra stuff. clang-formatting rr would make that a bit harder so we haven't done it. We probably should do it though, it's probably not that hard to manage.
 
What's a newbie to do?  I guess you're all busy with Pernosco?  How's that going?  Does it make Rust debuggable?

I'll let Kyle answer that if he wants to :-).

If you want to contribute to rr, please do and just ignore the formatting recommendation. If you really dislike the inconsistent formatting you can prod me and Kyle to fix it.

Rob
--
Su ot deraeppa sah dna Rehtaf eht htiw saw hcihw, efil lanrete eht uoy ot mialcorp ew dna, ti ot yfitset dna ti nees evah ew; deraeppa efil eht. Efil fo Drow eht gninrecnoc mialcorp ew siht - dehcuot evah sdnah ruo dna ta dekool evah ew hcihw, seye ruo htiw nees evah ew hcihw, draeh evah ew hcihw, gninnigeb eht morf saw hcihw taht.
Reply all
Reply to author
Forward
0 new messages