Current code style?

5 views
Skip to first unread message

Brian Murphy

unread,
May 14, 2026, 5:15:10 PMMay 14
to rr-devel
The `CONTRIBUTING.md` file in the project says"
```
- [ ] Did you check your code is formatted correctly? It's easiest to run `scripts/reformat.sh` on each commit.
```
but running that script on the current master branch yields many many changes.

What's a newbie to do?  I guess you're all busy with Pernosco?  How's that going?  Does it make Rust debuggable?

-Brian

Robert O'Callahan

unread,
May 15, 2026, 7:33:50 PMMay 15
to Brian Murphy, rr-devel
On Fri, 15 May 2026 at 09:15, Brian Murphy <brianr...@gmail.com> wrote:
The `CONTRIBUTING.md` file in the project says"
```
- [ ] Did you check your code is formatted correctly? It's easiest to run `scripts/reformat.sh` on each commit.
```
but running that script on the current master branch yields many many changes.

Yeah.

Pernosco maintains a private branch of rr with some extra stuff. clang-formatting rr would make that a bit harder so we haven't done it. We probably should do it though, it's probably not that hard to manage.
 
What's a newbie to do?  I guess you're all busy with Pernosco?  How's that going?  Does it make Rust debuggable?

I'll let Kyle answer that if he wants to :-).

If you want to contribute to rr, please do and just ignore the formatting recommendation. If you really dislike the inconsistent formatting you can prod me and Kyle to fix it.

Rob
--
Su ot deraeppa sah dna Rehtaf eht htiw saw hcihw, efil lanrete eht uoy ot mialcorp ew dna, ti ot yfitset dna ti nees evah ew; deraeppa efil eht. Efil fo Drow eht gninrecnoc mialcorp ew siht - dehcuot evah sdnah ruo dna ta dekool evah ew hcihw, seye ruo htiw nees evah ew hcihw, draeh evah ew hcihw, gninnigeb eht morf saw hcihw taht.

Kyle Huey

unread,
May 18, 2026, 2:24:57 PMMay 18
to rob...@ocallahan.org, Brian Murphy, rr-devel
Hi Brian,

What's your goal here? If you're trying to improve Rust debugging there's little to do in rr itself. The issues there are either in the debugger frontend (which with rr is gdb/lldb) or in the debugging information generated by the compiler (i.e. in rustc/LLVM). Pernosco improves the debugging frontend part of that. I can give you a bunch of trial credits if you want to play with it.

If you want to contribute to rr itself but don't have any particular goal, I think #3328 and #4024 are "good first bugs".

- Kyle

--
You received this message because you are subscribed to the Google Groups "rr-devel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rr-devel+u...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/rr-devel/CAOp6jLbXdZJY_qVwWJc2pGfSMGXDyq868LXEdGR-3TN1t1%3DiUg%40mail.gmail.com.

Brian R. Murphy

unread,
May 18, 2026, 6:59:47 PMMay 18
to Kyle Huey, rob...@ocallahan.org, rr-devel
At the moment I was just trying to debug some C code, and encountered #1180 and was thinking of submitting a fix.  (Due to using a "Strix Point" processor I had to build from source, though some of the issues may have been permissions/capabilities issues due to more security-minded features in the Linux kernel these days.)

Since your docs mention Rust support, I thought I may as well ask.  I kind of turned back to C++ from Rust about a year ago due to painful debugging experience there (despite the language being so neat in some other ways) so I thought I'd throw that out there.  I know the real issue is type/value modeling in the debugging info but you never know; a business venture with real customers might have to address pain points like that, even if it's not the primary focus.

-Brian
Reply all
Reply to author
Forward
0 new messages