Comment on revision r193 in roster-dns-management

[roster-dns...@googlecode.com]

sharrell.purdue commented on revision r193 in project roster-dns-management.
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=193


Line-by-line comments:

File: /trunk/roster-core/roster_core/__init__.py (r193)
===============================================================================

Line 43: import roster_schema_file
-------------------------------------------------------------------------------
put these in the same file

File: /trunk/roster-core/roster_core/roster_schema_file.py (r193)
===============================================================================

Line 1: SCHEMA_FILE = """# Copyright (c) 2009, Purdue University
-------------------------------------------------------------------------------
fix unittests to import this instead of reading it from another file

File: /trunk/roster-core/scripts/roster_database_bootstrap (r193)
===============================================================================

Line 50: SCHEMA_LOCATION = '/usr/share/roster/database_schema.sql'
-------------------------------------------------------------------------------
set this in the flags

Line 107: parser.add_option('--big-lock-wait', action='store',
-------------------------------------------------------------------------------
Add file locations as flags and set reasonable defaults

Line 208: os.mkdir('/usr/share/roster')
-------------------------------------------------------------------------------
this needs to go in etc, not here

File: /trunk/roster-server/roster_server/server.py (r193)
===============================================================================

Line 46: import sys #FIXME
-------------------------------------------------------------------------------
fix it!

Line 287: for path in sys.path:
-------------------------------------------------------------------------------
this whole thing needs deleted

File: /trunk/roster-user-tools/roster_user_tools/__init__.py (r193)
===============================================================================

Line 41: __all__ = ['roster_user_tools_config']
-------------------------------------------------------------------------------
make an embedded_files.py then import that

File: /trunk/roster-user-tools/setup.py (r193)
===============================================================================

Line 1: #!/usr/bin/env python
-------------------------------------------------------------------------------
add new tool for exporting roster user config file

Line 81: data_files = [('share/roster',
['etc/roster_user_tools.conf'])]
-------------------------------------------------------------------------------
this should be removed

Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=193
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings