Comment on revision r64 in roster-dns-management

[codesite...@google.com]

sharrell.purdue commented on revision r64 in project roster-dns-management.
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=64

Line-by-line comments:

File: /trunk/roster-server/roster_server/credentials.py (r64)
===============================================================================

Line 65: #self.binddn =
self.config_instance.config_file['credentials']['binddn']
-------------------------------------------------------------------------------
remove this please

File: /trunk/test/general_ldap.py (r64)
===============================================================================

Line 23: print server
-------------------------------------------------------------------------------
probably shouldnt print here

Line 26: if( tls == 'on' ):
-------------------------------------------------------------------------------
in the config file, comment it and say we are only accepting on and off,
then check like if tls.lower() == 'on' then throw an error if it's not on
or off

Line 35: ldap_server.protocol_version = eval('ldap.%s' % version)
-------------------------------------------------------------------------------
use getattr instead of eval

Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=64
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings