Comment on revision r19 in roster-dns-management

[codesite...@google.com]

sharrell.purdue commented on revision r19 in project roster-dns-management.
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=19

General Comment:
A few comments about this script, overall it looks fine.

Line-by-line comments:

File: /trunk/roster-config-manager/scripts/dnscheckconfig (r19)
===============================================================================

Line 43: import ConfigParser
-------------------------------------------------------------------------------
is this needed? I didn't see it used.

Line 68: handle = os.popen('/usr/sbin/named-checkconf %s' % file)
-------------------------------------------------------------------------------
need to check that named-checkconf exists before calling it, also have a
flag to point to it if need be. It could be in a different place.

Line 72: sys.stdout.write('.')
-------------------------------------------------------------------------------
Why dare you writing this dot?

Line 80: for file in zone_files:
-------------------------------------------------------------------------------
file is a reserved word, make it something else.

Line 89: print 'ERROR: Could not find $ORIGIN'
-------------------------------------------------------------------------------
print what file you couldn't find origin in.

Line 91: handle = os.popen('/usr/sbin/named-checkzone %s %s' % (origin,
file))
-------------------------------------------------------------------------------
check for named checkzone, same above

Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=19
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings