Comment on revision r150 in roster-dns-management
roster-dns...@googlecode.com
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=150
Line-by-line comments:
File: /trunk/roster-core/roster_core/core_helpers.py (r106)
===============================================================================
Line 44: import core
-------------------------------------------------------------------------------
need to keep core for RecordError
File: /trunk/roster-core/roster_core/core_helpers.py (r150)
===============================================================================
Line 79: range = ip_parts.pop(0).split('-')
-------------------------------------------------------------------------------
range is a reserved word, please leave it as ip_range like before
Line 574: raise RecordError('Record already exists with
that target '
-------------------------------------------------------------------------------
umm there is no RecordError defined, so you need to pull it from core
Line 617: def CIDRtoOrigin(self, cidr_block):
-------------------------------------------------------------------------------
this doesn't actually print an origin does it?
Where is this used?
Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=150
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings