Comment on revision r152 in roster-dns-management

[roster-dns...@googlecode.com]

sharrell.purdue commented on revision r152 in project roster-dns-management.
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=152

Line-by-line comments:

File: /trunk/roster-user-tools/roster_user_tools/cli_common_lib.py (r152)
===============================================================================

Line 45: """Arguemnt Error Exception"""
-------------------------------------------------------------------------------
In general you don't need to make docstrings for Error classes so please
remove this.

File: /trunk/roster-user-tools/roster_user_tools/cli_record_lib.py (r152)
===============================================================================

Line 47: """Creates cli common instance"""
-------------------------------------------------------------------------------
umm, this takes a cli common instance, not creates it, also you need inputs
on this doc string

File: /trunk/roster-user-tools/roster_user_tools/roster_client_lib.py (r152)
===============================================================================

Line 47: """Invalid Credentials Exception"""
-------------------------------------------------------------------------------
no docstring needed here

File: /trunk/test/cli_record_lib_test.py (r152)
===============================================================================

Line 81: """Std out redefined"""
-------------------------------------------------------------------------------
typically doc strings arent needed in the unittests, but you should go
ahead and leave this one.

Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=152
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings