Comment on revision r65 in roster-dns-management
codesite...@google.com
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=65
Line-by-line comments:
File: /trunk/test/general_ldap.py (r65)
===============================================================================
Line 32: 'Option "tls" must be set to "on" or "off", '
-------------------------------------------------------------------------------
looks like you have an extra ' there
Line 36: ldap_server.protocol_version = get_attr(ldap, version)
-------------------------------------------------------------------------------
pretty sure this function should be getattr not get_attr
Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=65
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
codesite...@google.com
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=65
Line-by-line comments:
File: /trunk/test/general_ldap.py (r65)
===============================================================================
Line 1: import ldap
-------------------------------------------------------------------------------
This is the wrong directory for this file, why is this in test?