Comment on revision r190 in roster-dns-management

[roster-dns...@googlecode.com]

sharrell.purdue commented on revision r190 in project roster-dns-management.
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=190


Line-by-line comments:

File: /trunk/roster-core/scripts/roster_database_bootstrap (r190)
===============================================================================

Line 151: parser.add_option('-s', '--schema-file', action='store',
dest='schema_file',
-------------------------------------------------------------------------------
where is the schema file going to be? I think we need to remove this and
default it as a constant and have a consistent place the schema file will
be.

Line 294: init_file = open(INIT_LOCATION, 'w')
-------------------------------------------------------------------------------
open should be above the try

Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=190
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings

[roster-dns...@googlecode.com]

alwayschooseford commented on revision r190 in project

roster-dns-management.
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=190

General Comment:
Ok, well for the time being I embedded the schema file. But there has to be
a better way, I have been looking and haven't found much that will just
install. I posted a question about it on pypi, as of now I haven't gotten a
reply.