Comment on revision r115 in roster-dns-management
roster-dns...@googlecode.com
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=115
Line-by-line comments:
File: /trunk/roster-user-tools/roster_user_tools/cli_common_lib.py (r115)
===============================================================================
Line 58: if( os.path.exists(config_file) ):
-------------------------------------------------------------------------------
this still isn't checking to see if the flags are there, it needs to check
both, if I try and do something without the server flags and it can't find
the config file then it gives me a nasty error.
Respond to these comments at
http://code.google.com/p/roster-dns-management/source/detail?r=115
--
You received this message because you starred this review, or because
your project has directed all notifications to a mailing list that you
subscribe to.
You may adjust your review notification preferences at:
http://code.google.com/hosting/settings
roster-dns...@googlecode.com
Details are at
http://code.google.com/p/roster-dns-management/source/detail?r=115
Line-by-line comments:
File: /trunk/roster-user-tools/roster_user_tools/cli_common_lib.py (r115)
===============================================================================
Line 59: a = self.config_file.read(config_file)
-------------------------------------------------------------------------------
This change breaks many, many unittests, make sure they are fixed before
you check something else in.