|
||
As a continuation of I noticed a lot of unexpected hard coded paths in the binary releases of alpha 8. Note that I only checked Windows and Linux. In the Linux installation directions at https://github.com/ros2/ros2/wiki/Linux-Install-Binary, it mentions putting the release in "~/ros2_install" and yet I see a lot of references to /home/rosbuild/ci_scripts/ws. In the Windows installation instructions at https://github.com/ros2/ros2/wiki/Windows-Install-Binary, it mentions putting the release in "C:\dev\ros" and yet I see a lot of references to "C:\J\workspace\packaging_windows\ws". The biggest issues that I noticed so far is the inability to link to the TF2 library on Windows and the inability to run ament directly on Linux. Can we get the binary releases to match the installation instructions? Specific details are below: py3.5.egg-info ros2-windows\CMake\console_bridge-config.cmake all the scripts in the ros-linux/bin/python and ros-linux/bin/launch have the #!/home/rosbuild/ci_scripts/venv/bin/python shebang in ros2-linux\lib\console_bridge\cmake\console_bridge-config.cmake ros2-linux\local_setup.sh (2 hits) |
Visit Topic or reply to this email to respond.
To unsubscribe from these emails, click here.
|
||
I will focus on the Linux release in this post. Can you please clarify what exactly you mean with "a lot of unexpected hard coded paths". I could guess and will also comment on some classes of cases below but I think it would be helpful if you could state specific examples when referring to issues. The following groups of cases are the ones I am aware of. If you noticed more cases please add them explicitly:
|
|
||
Thanks Dirk. By "a lot of unexpected hard coded paths", I meant that I wasn't sure if they needed to be there or how they influence the system. You touched on all the details. They seemed like a red flag, but it sounds like you're aware of them. |
|
||
I took the opportunity to also look at the Windows archive and found the following cases:
|
|
So the list seems to be much shorter on Windows since:
Therefore I would conclude that we need to follow up on two items:
|
|
||
Based on your post I spend some time on these "annoying details" and was able to resolve three of them:
I have updated the previous posts with the current state. If anyone has an idea how to resolve the remaining ones I would be more then happy to hear them. (Or if you would like to create a pull request for |