running uncrustify during 'ament test' using custom rules

Brad Baillio

unread,

Jun 20, 2016, 5:44:08 PM6/20/16

to ROS SIG NG ROS

Is it possible to specify your own uncrustify rules file during the ament test call?

I can make it work when running ament_uncrustify standalone, but I would like to check my custom rules during the test phase.

Is this possible?

Thanks.

Dirk Thomas

unread,

Jun 20, 2016, 5:54:35 PM6/20/16

to ROS SIG NG ROS

Hi Brad,

Currently the CMake function (https://github.com/ament/ament_lint/blob/bbc24f8470f27b1533faffafcda1b128adab5463/ament_cmake_uncrustify/cmake/ament_uncrustify.cmake) doesn't have an argument to specify a custom configuration file. But that should be easy to add. It would also be good to allow setting a "global" variable like AMENT_UNCRUSTIFY_CONFIGURATION which is being iused in the case where `ament_lint_auto` is being used. If you could provide a pull request to support this use case that would be great.

Thanks,

- Dirk

--
You received this message because you are subscribed to the Google Groups "ROS SIG NG ROS" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ros-sig-ng-ro...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Brad Baillio

unread,

Jun 21, 2016, 11:21:00 AM6/21/16

to ROS SIG NG ROS

Right on. I'll see if I can work on that. :-)

Reply all

Reply to author

Forward