On Fri, Apr 14, 2017 at 01:29:49PM -0700, Corey Walsh wrote:
> I'd like some pointers on how to best integrate with AMCL to avoid lots
> of rework if my initial integration does live up to AMCL conventions/
> best practices, so I will file an issue on the repository with details.
Sounds like a good idea. Although a working implementation,
fitting the conventions or not, usually is a good idea too.
People can test it right away. Also in case you loose interest before
it is merged, someone else can continue on that work later on more easily.
> Good to hear you are open to these changes!
Sorry, I didn't mean to confuse! Apparently I have commit access
to the repository in question, but I'm not one of its core maintainers.
That would be David Lu!! and Michael Ferguson. They seem to be
a bit behind on reviewing/merging pull-requests, although things happen there.
The navigation stack is quite crucial to most ROS users, so they probably
do not want to merge prematurely and only after proper testing.
The same clearly applies to your ideas too.
But if there is significant performance gain and features are well-tested,
In my opinion they are welcome. :)