On 12/11/15 23:29, Mike Purvis wrote:
> Hi folks,
>
> Clearpath would like to make available a driver for the OMRON OS32C
> EtherNet/IP-based safety laser:
>
>
https://www.ia.omron.com/products/family/2717/
>
> The source is here at the moment (the in-source license banners will be
> changed to BSD shortly):
>
>
https://github.com/mikepurvis/os32c
>
> The most significant issues I foresee revolve around naming and bundling.
> Specifically:
>
> - Is the os32c name acceptable, or should it be renamed to
> omron_laser_driver, os32c_driver, os32c_laser_driver, or something along
> those lines?
A few months ago REP-144 was introduced [1], which provides some
suggestions as to how pkgs should be named. Combining Shauns suggestion
with that, perhaps 'omron_os32c_driver' would be the most descriptive name?
> - Regarding the bundled eip (EtherNet/IP) library, should this be split
> out into a separate package (odva_ethernet_ip), either within this repo, or
> possibly its own? It's intended to be reusable, it just doesn't have any
> other consumers at present.
Definitely split it out. A library for eip would be a prime reuse
candidate, so to me it wouldn't make sense to keep this so tightly
coupled (in a distribution sense) with this driver.
I haven't looked at it yet, but does your implementation support
implicit messaging? That is what most other open-source libraries are
missing at the moment.
> If there's no objection, I'll create a github repo in ros-drivers and set
> up a page on the ROS Wiki. There's development/cleanup still under way with
> this driver, but it is in a usable state at present, and the ongoing
> development may as well occur in the final location, for the sake of
> setting up buildfarm jobs, etc.
>
> Mike
Gijs
[1]
https://github.com/ros-infrastructure/rep/pull/96