Some suggestions and questions

[jimmy]

Hi,


in regard to steps/060-ssh_keys, this line

return unless i_has("user") || i_has("ssh_keys_add");

why is the i_has("user") statement here, just performing the
user steps will cause the ssh_keys to run as well, which may be not
the intention.


I noticed that on my system running rolloutd, there are many
defunct child rolloutd processes. I suggest adding a statement
( $SIG{CHLD} = 'IGNORE';) to avoid keeping these zombie processes
around. As shown below


360 if ($daemon) {
361 # Become a daemon
362 defined(my $pid = fork()) or die "Couldn't fork: $!";
363 exit if $pid;
364 $SIG{HUP} = 'IGNORE';
365 # eliminate all the defunct processes
-> 366 $SIG{CHLD} = 'IGNORE';
367 setsid or die "Couldn't start a new session: $!";

rgds


Jimmy

[David Parrish]

On Wed, Aug 25, 2010 at 4:54 PM, jimmy <jimmy...@gmail.com> wrote:
> in regard to   steps/060-ssh_keys,   this  line
>
> return unless i_has("user") || i_has("ssh_keys_add");
>
> why is the   i_has("user")    statement  here,   just performing  the
> user steps will cause the ssh_keys to run as well, which may be not
> the intention.

The "user" block is checked because each individual user can have ssh keys installed. I've fixed up the code so that it works but won't error if authorized_keys doesn't exist and there are no keys required to be added.

> I noticed that on my system running rolloutd,  there are  many
> defunct  child  rolloutd  processes. I suggest  adding a statement
> ( $SIG{CHLD} = 'IGNORE';)   to avoid keeping these zombie processes
> around.  As shown  below

Fixed, thanks very much.

These changes have been pushed to github.