Non-idempotency of expandVariables

[Timothy Peierls]

Currently Rocoto.expandVariables is not idempotent. For example, the following tests pass:

public class RocotoTest {

    static class AModule extends ConfigurationModule {

        @Override protected void bindConfigurations() {

            bindProperty("aprop").toValue("avalue");

        }

    }

    static class CModule extends ConfigurationModule {

        @Override protected void bindConfigurations() {

            bindProperty("cprop").toValue("${nodef|${aprop}}");

        }

    }

    static class Injected {

        @Inject @Named("aprop") String avalue;

        @Inject @Named("cprop") String cvalue;

    }

    @Test public void testSingleExpansion() throws Exception {

        Injected injected = Guice.createInjector(Rocoto.expandVariables(

            new AModule(),

            new CModule()

        )).getInstance(Injected.class);

        assertEquals("${aprop}", injected.cvalue);

    }

    @Test public void testDoubleExpansion() throws Exception {

        Injected injected = Guice.createInjector(Rocoto.expandVariables(

            new AModule(),

            Rocoto.expandVariables(new CModule())

        )).getInstance(Injected.class);

        assertEquals("avalue", injected.cvalue);

    }

}

In testSingleExpansion, the value ${nodef|${aprop}} is expanded to ${aprop}, while in testDoubleExpansion, the ${aprop} is further resolved to avalue. This makes sense, but is it really desirable? Is it ever the case that one wants unexpanded ${} expressions in default values? 

Not sure myself, which is why I'm posting.

--tim

[Simone Tripodi]

Hi Tim!

can you attach the test, in a form that doesn't need to be copied and
recoded, somewhere - maybe in your GitHub fork - so we can have a look
at it?

Many thanks in advance, have anice weekend!

-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/

[Timothy Peierls]

Some day I'll get with the program and learn how to use git and GitHub. Until then, I've placed the test class here:

http://pastebin.com/F2D4T5YD 

It should be possible to drop right into any JUnit 4 setup.

--tim

[Simone Tripodi]

Hi Tim!!

nice, I'm having a look at your test this evening!

Thanks a lot, all the best,
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/