2014/1/10 Mykhailo Poliarush <
pol...@gmail.com>:
> I've done small changes to XML library and rewrote it based on lxml library.
Have you considered submitting the enhancements back to the original
library? It would be great if the original library could be configured
to use lxml too. The main benefit of ElementTree compared to it is
that lxml needs to be installed separately and that installation is
also somewhat complicated in some environments.
> Extra method added:
>
> get_elements_texts
> elements_text_should_be
> elements_text_should_match
> elements_text_should_match_regexp
> elements_should_match
> elements_should_be_equal
> elements_count_should_be_equal
> set_elements_attribute
> set_elements_tag
> set_elements_text
These seem to be all related to handling multiple elements at once. If
that's a common use case, such keywords could obviously be added to
the original library too.
>
https://github.com/polusok/robotframework-lxmllibrary
I looked at the project and noticed you had copied some source files
from Robot Framework and removed copyrights at least from some of
them. The former is fine but the latter is one of the few things that
are forbitten by the Apache 2 license
<
http://www.apache.org/licenses/LICENSE-2.0.html>. See especially
points b) and c) under section 4. Redistribution:
b) You must cause any modified files to carry prominent notices
stating that You changed the files; and
c) You must retain, in the Source form of any Derivative Works
that You distribute, all copyright, patent, trademark, and attribution
notices from the Source form of the Work, excluding those notices that
do not pertain to any part of the Derivative Works; and
Cheers,
.peke
--
Agile Tester/Developer/Consultant ::
http://eliga.fi
Lead Developer of Robot Framework ::
http://robotframework.org