Issue 243 in robotframework-seleniumlibrary: addCustomRequestHeaders doesn't work

11 views
Skip to first unread message

robotframework-...@googlecode.com

unread,
Jun 21, 2012, 10:15:08 AM6/21/12
to robotframework-se...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 243 by chmielss...@gmail.com: addCustomRequestHeaders doesn't work
http://code.google.com/p/robotframework-seleniumlibrary/issues/detail?id=243

With current version command:
selenium.addCustomRequestHeaders doesn't work - it does return success but
is ineffective - user specified headers are not added to requests. Selenium
server is missing parameter addCustomRequestHeaders=true when initializing
new session.

Proposed patch:


--- selenium.py 2012-03-19 19:57:19.000000000 +0100
+++ selenium.py 2012-06-21 16:02:41.666887363 +0200
@@ -186,7 +186,6 @@
start_args = [self.browserStartCommand, self.browserURL,
self.extensionJs]
if browserConfigurationOptions:
start_args.append(browserConfigurationOptions)
- start_args.append("addCustomRequestHeaders=true")
result = self.get_string("getNewBrowserSession", start_args)
try:
self.sessionId = result


robotframework-...@googlecode.com

unread,
Jun 25, 2012, 11:00:53 AM6/25/12
to robotframework-se...@googlegroups.com

Comment #1 on issue 243 by chmielss...@gmail.com: addCustomRequestHeaders
Of course patch above is reversed - simple mistake.

Reply all
Reply to author
Forward
0 new messages