Adding unit test to ShadowBluetoothGatt

[Kevin Lockwood]

There is a missing API call in ShadowBluetoothGatt I would like to add, as its needed for a full API state machine test.  BluetoothGatt#setPreferredPhy.  I have a tentative CL I would like to push in g3 on Critique.  Who would be best to assign as reviewers?

There are two other new APIs in BluetoothGatt/BluetoothGattCallback that I would eventually like to add as well to keep this Shadow up to date with current available APIs.

Thanks,

KL

[Kevin Lockwood]

Perhaps bad nomenclature.  I mean add new API to ShadowBluetoothGatt (setPreferredPhy),  for production code unit testing.  

[Gaëtan Muller]

Hey Kevin,

The BluetoothGatt#setPreferredPhy() method was added recently via https://github.com/robolectric/robolectric/pull/10616. So it will probably be included in Robolectric 4.17.

For the other APIs that you would like to add, feel free to send a PR on https://github.com/robolectric/robolectric if they are not yet available on the master or google branches.

[Kevin Lockwood]

Thanks Gaëtan!

--
You received this message because you are subscribed to the Google Groups "Robolectric" group.
To unsubscribe from this group and stop receiving emails from it, send an email to robolectric...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/robolectric/ccb0ce63-5ca3-4d97-899a-29cc23a0e807n%40googlegroups.com.