common.h.msvc80 seems to be missing

18 views
Skip to first unread message

Sean

unread,
Feb 9, 2010, 12:47:49 PM2/9/10
to rlog-users
I'm guessing this is a pre-configured common.h for use with visual
studio. It doesn't seem to be in the release tarball or in the svn
repo.

I was able to hack around it by configuring on linux and then
modifying the RLOG_DECL definition:

#ifdef _WIN32
#ifdef RLOG_EXPORT
#define RLOG_DECL __declspec(dllexport)
#else
#define RLOG_DECL __declspec(dllimport)
#endif
#else
#define RLOG_DECL
#endif

Adding the RLOG_EXPORT define to the preprocessor settings when
compiling the dll.

I was also wondering if it's possible to obtain RLog under a different
license that would allow static linking. Perhaps a CMake-based build
system would be a reasonable trade for this?

Valient Gough

unread,
Feb 10, 2010, 4:35:16 PM2/10/10
to rlog-...@googlegroups.com
Which license did you have in mind? I'm not opposed to static
linking. What I'd like to retain is a requirement to share any
changes to rlog with anyone that gets a modified version - regardless
of how it's linked into the program.

Valient

Sean McAllister

unread,
Feb 10, 2010, 6:36:26 PM2/10/10
to rlog-...@googlegroups.com
Something like the Apple Public license would work well: http://www.opensource.org/licenses/apsl-2.0.php
It seems to allow you to link and distribute applications however you want, but requires source code be provided
for any modifications you make to the library.  Gets rid of the re-linking requirement of the LGPL.

Sean


--
You received this message because you are subscribed to the Google Groups "rlog-users" group.
To post to this group, send email to rlog-...@googlegroups.com.
To unsubscribe from this group, send email to rlog-users+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/rlog-users?hl=en.


Sean McAllister

unread,
Feb 10, 2010, 6:47:38 PM2/10/10
to rlog-...@googlegroups.com
The Sun Public license also seems appropriate: http://www.opensource.org/licenses/sunpublic.php

Sean McAllister

unread,
Feb 11, 2010, 3:23:56 PM2/11/10
to rlog-...@googlegroups.com
Do you have any hints on getting the dll build working on windows, I'm running up against a wall getting it to recognize the _RLDebugChannel symbol.  I modified RlogChannels.cpp to have the right export statements:

    RLOG_DECL RLogChannel *_RLDebugChannel   = GetGlobalChannel( "debug",   Log_Debug );
    RLOG_DECL RLogChannel *_RLInfoChannel    = GetGlobalChannel( "info",    Log_Info );
    RLOG_DECL RLogChannel *_RLWarningChannel = GetGlobalChannel( "warning", Log_Warning );
    RLOG_DECL RLogChannel *_RLErrorChannel   = GetGlobalChannel( "error",   Log_Error );

And I can see the symbols are exported in the dll using pe explorer, but my code can't seem to find them.  Maybe I just don't know how to export variables in a namespace properly...  (static linkage sure would be easier ;) )
Reply all
Reply to author
Forward
0 new messages