Wrong comments on mines-sarsa?

12 views
Skip to first unread message

Alejandro

unread,
May 19, 2011, 4:02:32 PM5/19/11
to rl-li...@googlegroups.com
Hi:

I think the comments that explain the meaning of the actions in the mine-sarsa-* examples are wrong. For example this is from
svn/trunk/projects/packages/examples/mines-sarsa-python/sample_mines_environment.py :

(lines 177 to 187)
		if (theAction == 0):#move down
newCol = self.agentCol - 1;

if (theAction == 1): #move up
newCol = self.agentCol + 1;

if (theAction == 2):#move left
newRow = self.agentRow - 1;

if (theAction == 3):#move right
newRow = self.agentRow + 1;

I think changing the value of the columns corresponds to left/right movement, and changing the value of the rows corresponds to up/down movements (the opposite of what the comments say).

Alejandro.


Brian Tanner

unread,
May 31, 2011, 12:37:09 PM5/31/11
to rl-library
You're probably right, those comments could be updated to be more
intuitive if they don't correspond to what the viewer shows. Other
than that it's really fairly arbitrary.
Reply all
Reply to author
Forward
0 new messages