Ring Errors Question

[Youssef Saeed]

Hello Mahmoud,

Would it be possible to use a non-zero exit status when an error occurs in a ring program?

I believe that every time an error occurs, there should be a non-zero exit status:

exit(RING_EXIT_FAIL);

Best regards,
Youssef

[Mahmoud Fayed]

Hello Youssef

Thanks for the report :D

Updated in this commit: Update Visual Source (Using PWCT) - Revise exit() usage - Reported by… · ring-lang/ring@7525e69

Greetings,

Mahmoud

[Youssef Saeed]

Hello Mahmoud,

Thank you very much for the quick fix.

Best regards,
Youssef

[Mahmoud Fayed]

Hello Youssef

You are welcome :D

Greetings,

Mahmoud

[Youssef Saeed]

Hello Mahmoud,

I think the raise and assert functions should also exit with RING_EXIT_FAIL.

Best regards,
Youssef

[Mahmoud Fayed]

Hello Yousef

>> "I think the raise and assert functions should also exit with RING_EXIT_FAIL."

These functions use RING_API_ERROR which call ring_vm_error()

In ring_vm_error() we use RING_EXIT_FAIL

In this line: ring/language/src/vmerror.c at master · ring-lang/ring

Greetings,

Mahmoud

[Youssef Saeed]

Hello Mahmoud,

Thank you for the clarification.

Best regards,
Youssef

[Mahmoud Fayed]

Hello Youssef

You are welcome :D

Greetings,

Mahmoud

[Mansour Ayouni]

Hello Mahmoud,

Do this fix have any impact in existant programs?

Best,
Mansour

--

---
You received this message because you are subscribed to the Google Groups "The Ring Programming Language" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ring-lang+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/ring-lang/bfef39f6-8019-4692-966c-71707e60babcn%40googlegroups.com.

[Mahmoud Fayed]

Hello Mansour

>> "Do this fix have any impact in existent programs?"

This update is five months old

i.e. it's already applied in Ring 1.22

It's useful when we run Ring programs through batch files/scripts then check the program output 

Check: Errorlevel - Windows CMD - SS64.com

Greetings,

Mahmoud

[Mansour Ayouni]

Hello Mahmoud,

Thank you for your clarification!

All the best,

Mansour

To view this discussion visit https://groups.google.com/d/msgid/ring-lang/03df6c5d-c92d-41b7-8501-6beb065f2751n%40googlegroups.com.

[Mahmoud Fayed]

Hello Mansour

You are welcome :D

Greetings,

Mahmoud

[Youssef Saeed]

Hello Mahmoud,

While doing more testing, I found that when a syntax error occurs, Ring exits with a status code of 0 (success). A similar script tested with Python correctly exits with 1.

For example:

Ring:

ring test.ring; echo "Ring script exited with: $?"
Error (S1) In file: test.ring
In Line (1) Literal not closed
Ring script exited with: 0

Python:

python test.py; echo "Python script exited with: $?"
  File "/test.py", line 1
    print("llll
          ^
SyntaxError: unterminated string literal (detected at line 1)
Python script exited with: 1

This bug prevents reliable error checking in scripts and CI/CD pipelines.

Best regards,
Youssef

[Mahmoud Fayed]

Hello Youssef

Thanks for the report

Fixed in this commit:  Update Visual Source (Using PWCT) - ring_state_execute() function - c… · ring-lang/ring@bf4d50b

Please test and see if this solves the reported issue

Greetings,

Mahmoud

[Youssef Saeed]

Hello Mahmoud,

Thank you so much for the incredibly quick fix!

I've just tested the latest changes, and I can confirm that the issue is now resolved. Ring correctly exits with a non-zero status code on syntax errors, which is the expected behavior.

Here is the output from my test:

ring test.ring; echo "Ring script exited with: $?"
Error (S1) In file: test.ring
In Line (1) Literal not closed

Ring script exited with: 1

Best regards,
Youssef

[Mahmoud Fayed]

Hello Youssef

You are welcome :D

Greetings,

Mahmoud