[rubyredrick/ri_cal] 4918ba: fixed infinite loop bug for reported case
nor...@github.com
Home: http://github.com/rubyredrick/ri_cal
Commit: 4918baedeb9d7f61795a0cc141dd2c685e810864
http://github.com/rubyredrick/ri_cal/commit/4918baedeb9d7f61795a0cc141dd2c685e810864
Author: Rick DeNatale <rick.d...@gmail.com>
Date: 2009-11-15 (Sun, 15 Nov 2009)
Changed paths:
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer/by_day_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer/by_monthday_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer/by_numbered_day_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer/by_weekno_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer/frequency_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer/list_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer/null_sub_cycle_incrementer.rb
M lib/ri_cal/property_value/recurrence_rule/recurring_month_day.rb
M lib/ri_cal/property_value/recurrence_rule/recurring_year_day.rb
A spec/ri_cal/inf_loop_spec.rb
Log Message:
-----------
fixed infinite loop bug for reported case
Commit: 226fcf9bb6200d9478578d535cd5af615d511d59
http://github.com/rubyredrick/ri_cal/commit/226fcf9bb6200d9478578d535cd5af615d511d59
Author: Rick DeNatale <rick.d...@gmail.com>
Date: 2009-11-16 (Mon, 16 Nov 2009)
Changed paths:
M lib/ri_cal/property_value/recurrence_rule/occurrence_incrementer.rb
M spec/ri_cal/inf_loop_spec.rb
Log Message:
-----------
Working on a bug where a recurrence rule with simple by-parts caused an infinite loop
See spec/ri_cal/inf_loop_spec
Although the reported bug is fixed there is still work to do because giving an event a dtstart
not within the recurrence rule produces incorrect output.
1) 'an event with unneeded by parts with a dtstart outside the recurrence rule should enumerate 10 events first July 12, 1940, July 13, 1940, July 13, 1941 when count is 3' FAILED
expected: ["1940-07-12", "1940-07-13", "1941-07-13"],
got: ["1940-07-12", "1940-07-13", "1941-07-12"] (using ==)
I'm going to push this to github, but not release a new gem version until I can fix this latter bug.