Why pull request doesn't update the changesets?

[Alex Yang]

Hi Team,

I found the pull request works very differently with bitbucket and github.

For example, I created a pull request like pull_1 with 2 changesets c_1 and c_2.

Then my team leader reviewed my pull request and gave me some comments. I pushed a changeset c_3 with my code updated according to the review comments.

But the problem is that pull_1 doesn't include the new c_3 changeset? Then team leader can't review the change until I created a new pull request.

Is it by design of RhodeCode or a missing feature? I just tried bitbucket and github both support this scenario. The benefit is that you don't need to create multiple pull requests for a tiny change. Meanwhile you can maintain all conversation log in the same pull request.

What do you think? Looking forward to your opinions.

Thanks,

Alex Yang

[Marcin Kuzminski]

Hi,

I seen your tickets on bitbucket, thanks for reporting, we didn't implement the autoupdate of changesets yet but it's actually my next task i want to do. Expect that implemented very soon.

Cheers

Marcin Kuzminski

--
You received this message because you are subscribed to the Google Groups "rhodecode" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rhodecode+...@googlegroups.com.
To post to this group, send email to rhod...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Alex Yang]

Hi Marcin,

Thanks for your reply. Great to here your plan. I even can't wait to see this feature now. It would benefit the code review obviously.

BTW, another "update" feature: 

When fork in RhodeCode, is the forked repo reminded to update like bitbucket and git? such as a label saying: your fork is 35 changesets behind the original repo, click this link to update. I would highly expect update for fork repo in RhodeCode too, besides the update for pull request.  Then it should be perfect ^_^

Thanks,

Alex Yang