Pull requests

[David Gillies]

Hi,

I've just upgraded to 1.4.3 the other day from 1.3.6 and one of the feature I was looking forward to using was pull requests. I'm a bit confused though. I do the following to raise a pull request:

1. fork repo

2. make changes

3. push to fork

4. in the repo page in rhodecode, options, open new pull request and submit

5. in the repo where I where the pull is requested against, I open the request, comment and approve it

6. ???

After approval of the pull request, what then? I see the pull request as being approved but it never makes it into that repo. 

[marcin]

RhodeCode pull requests are now more like a "case" to review changesets. After you accept a pull request, You need to merge that yourself. This ends the flow. RhodeCode later will get the server side merging. That will do the step of manual merge.

[Juergen Schackmann]

Are there any plans for the future to integrate this step into the frontend such that you cannot only accept the request but actually to the pull as well?

[Marcin Kuzminski]

Yes, there's a ticket to add Merge button that will do server side merging of PR. That should be implemented soon.

Marcin Kuzminski

On Mon, Apr 29, 2013 at 4:44 PM, Juergen Schackmann <juergen.s...@gmail.com> wrote:

Are there any plans for the future to integrate this step into the frontend such that you cannot only accept the request but actually to the pull as well?

--
You received this message because you are subscribed to the Google Groups "rhodecode" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rhodecode+...@googlegroups.com.
To post to this group, send email to rhod...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
 
 

[Juergen Schackmann]

that is good news for a great feature

[William Leara]

Hi, I've read this thread and some others, but I'm still having difficultly understanding how the changes in the pull request actually get propagated to the destination repo.  I understand the server-side merging isn't ready yet (last I heard).  What is the manual process by which a user implements the changes he accepted in the pull request?  Thanks for the help.