Allow private_build_requires in dependency graph

[Ibrahim sani kache]

Hello,

I would like to propose optionally allowing private_build_requires in get_dependency_graph in rez.resolved_context. This is useful in capturing the full dependency graph of a package. 

e.g:

```

def get_dependency_graph(self, bool_include_private=False):

        . . . .

        for variant in self._resolved_packages:

            . . .

            for request in variant.get_requires(private_build_requires=bool_include_private):

                if not request.conflict:

                    edges.add((variant.name, request.name))

```

Cheers

[Allan Johns]

Hi,

This does not make sense, for two reasons.

First: A context is the result of running the solver algorithm, and the graph is a visual representation of that. Adding edges to it to graft in other data (a package's private build requires in this case) would change the meaning of this graph entirely.

Second: It doesn't make sense to add the private build requirements of all packages in a resolve - only one package (the one that got built) ever has its private build requirements added to an env request (its build env).

If the intent is to see the dependency graph for a real build env, that would contain a package's private-build-requires (as well as standard build-requires, and requires), then what you're actually asking for is a way to create that env, and that's reasonable.

What could be good is to add a new option to rez-env to give you that. For example, currently there is the -b option, but all that does is include all the build_requires of packages in the resolve. Perhaps we could add a -B option (which is more like, recreate the actual build env for a specific package). In this case, rez-env would be restricted to one PKG (the one to recreate the build env for) and would then include its private and public build requires.

Does this describe what you're after?

Thx

A

--
You received this message because you are subscribed to the Google Groups "rez-config" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rez-config+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rez-config/c5b8a0c0-ee19-4502-b53c-a37e6d7edd20n%40googlegroups.com.

[Ibrahim sani kache]

Hello Allan,

If the intent is to see the dependency graph for a real build env, that would contain a package's private-build-requires (as well as standard build-requires, and requires), then what you're actually asking for is a way to create that env, and that's reasonable. 

Yes, this is close to what I am after but I want the package build env to ( optionally ) include the private_build_requires of all the packages listed in it's requires if any. 

Here's what I am trying to solve, suppose I have package A with these requirements and some of them have inter-dependency with one another and package 'c' has package 'foo' as private_build_require:

```

requires = [ 'a', 'b', 'c', 'd', 'e'] 

```

If I have a code change that requires package 'foo' and every single package in package A requires to be rebuilt in this order a->d,e->foo->e->A, I need the solver to compute the resolve context by including the private_build_requires for all the packages listed in my package A. Because I need 'foo' rebuilt first before 'c', the graph needs to show 'foo' connected to 'c' ( [('c', 'foo')] ). This was something we were able to achieve in Rez1. 

Thanks 

You received this message because you are subscribed to a topic in the Google Groups "rez-config" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/rez-config/IY39RSZ8h8g/unsubscribe.
To unsubscribe from this group and all its topics, send an email to rez-config+...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/rez-config/CAGMneOempGumckOaUJTDbOaf%2BKWT-uWmuK2S8Kig%3Dq3a7p1a%2BA%40mail.gmail.com.

[Allan Johns]

Hi Ibrahim,

Ok, I see what you mean.

In that case then I propose we have a -B option that can optionally take a list of package names. If empty, this will then pull in the private build requires of all packages; otherwise, it'll pull in those for the listed packages only. That way we can use this one new option for two different scenarios - the one you point out above, but also to recreate the specific build env for a given package.

Cheers

A

To view this discussion on the web visit https://groups.google.com/d/msgid/rez-config/CA%2Bs3ri1C7tD5z%2BV5i5mJxsmwd5UpmDXCffSwUzrJ5Bp_n%3Di-Pw%40mail.gmail.com.

[Ibrahim sani kache]

Great! Sounds good Allan. 

Thanks. 

To view this discussion on the web visit https://groups.google.com/d/msgid/rez-config/CAGMneOfP99pJpw2dhoKeDfZp%3Dude0RJoPDs%3DwgtDTRTyH20Mgw%40mail.gmail.com.

[Ibrahim Sani Kache]

Hello Allan,

Is there an open issue for this one that I can follow?

Thanks.