Problem with devel build
bradh
I've previously set up the "release" version of ReviewBoard, and it is
working fine.
I'm now trying to set up a local reviewboard development environment
on a fairly clean Fedora 12 box - very similar to the release
configuration, since both were cloned from the same VM master.
I'm trying to follow the instructions at
http://www.reviewboard.org/docs/codebase/dev/getting-started/#gettingstarted
and it looks like its mostly working. The prepare-dev.py script ends
with "Your Review Board tree is ready for development."
When I run the devserver.sh script, I get:
[bradh@test reviewboard]$ ./contrib/internal/devserver.sh
Running dependency checks (set DEBUG=False to turn this off)...
Warning: p4python (>=07.3) not found. Perforce integration will not
work.
Warning: PyLucene (with JCC) is required to enable search. See the
documentation for instructions.
Warning: mtn binary not found. Monotone integration will not work.
Please see http://www.reviewboard.org/docs/manual/dev/admin/
for help setting up Review Board.
Validating models...
0 errors found
Django version 1.1.1, using settings 'reviewboard.settings'
Development server is running at http://0.0.0.0:8080/
Quit the server with CONTROL-C.
I can access the site using a web browser and the menus seem OK.
I have run the unit tests (with "./manage.py test") and it ends with
Ran 189 tests in 56.108s
OK (SKIP=5)
The skipped test appear related to perforce, which I don't have and
and don't care about.
When I try to set up the Repository, the menus I see don't really
match the documentation.
Eventually I found that if I add a tool (at "http://localhost:8080/
admin/db/scmtools/tool/") as Subversion and then svnx (where x can be
any character, it seems to chop the last letter off), then I can get
through the Repository setup (at "http://localhost:8080/admin/db/
scmtools/repository/add/") using the following entries:
Name: OpenChange
Show this repository selected
Path: https://svn.openchange.org/openchange
(remainder blank / defaulted)
When I press "save", the subsequent processing ends in a backtrace
that looks like this:
[31/Dec/2009 02:03:15] "GET /admin/db/scmtools/repository/add/ HTTP/
1.1" 304 0
[31/Dec/2009 02:03:16] "GET /admin/db/jsi18n/ HTTP/1.1" 200 353
2009-12-31 02:05:56,227 - ERROR - Exception thrown for user bradh at
http://localhost:8080/admin/db/scmtools/repository/add/
Item in ``from list'' not a string
Traceback (most recent call last):
File "/usr/lib/python2.6/site-packages/django/core/handlers/
base.py", line 92, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/usr/lib/python2.6/site-packages/django/contrib/admin/
sites.py", line 490, in root
return self.model_page(request, *url.split('/', 2))
File "/usr/lib/python2.6/site-packages/django/views/decorators/
cache.py", line 44, in _wrapped_view_func
response = view_func(request, *args, **kwargs)
File "/usr/lib/python2.6/site-packages/django/contrib/admin/
sites.py", line 509, in model_page
return admin_obj(request, rest_of_url)
File "/usr/lib/python2.6/site-packages/django/contrib/admin/
options.py", line 1092, in __call__
return self.add_view(request)
File "/usr/lib/python2.6/site-packages/django/db/transaction.py",
line 240, in _commit_on_success
res = func(*args, **kw)
File "/usr/lib/python2.6/site-packages/django/contrib/admin/
options.py", line 716, in add_view
if form.is_valid():
File "/home/bradh/reviewboard/reviewboard/scmtools/forms.py", line
580, in is_valid
return (super(RepositoryForm, self).is_valid() and
File "/usr/lib/python2.6/site-packages/django/forms/forms.py", line
120, in is_valid
return self.is_bound and not bool(self.errors)
File "/usr/lib/python2.6/site-packages/django/forms/forms.py", line
111, in _get_errors
self.full_clean()
File "/home/bradh/reviewboard/reviewboard/scmtools/forms.py", line
502, in full_clean
return super(RepositoryForm, self).full_clean()
File "/usr/lib/python2.6/site-packages/django/forms/forms.py", line
243, in full_clean
value = getattr(self, 'clean_%s' % name)()
File "/home/bradh/reviewboard/reviewboard/scmtools/forms.py", line
544, in clean_tool
scmtool_class = tool.get_scmtool_class()
File "/home/bradh/reviewboard/reviewboard/scmtools/models.py", line
23, in get_scmtool_class
mod = __import__(module, {}, {}, [attr])
TypeError: Item in ``from list'' not a string
[31/Dec/2009 02:05:56] "POST /admin/db/scmtools/repository/add/ HTTP/
1.1" 500 143128
I'm pretty much stuck at this point. Any help / suggestions would be
appreciated.
Christian Hammond
The documentation doesn't match because it covers 1.0.x, and you're
running the 1.1 (soon 1.5) development branch.
You shouldn't have to add the scmtools by hand. Did you run the
prepare-dev script? It should do it for you. If you did and it failed,
run 'setup.py install' and then ./reviewboard/manage.py
registerscmtools'
Christian
> --
> Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~----------~----~----~----~------~----~------~--~---
> To unsubscribe from this group, send email to reviewboard...@googlegroups.com
> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
Brad Hards
Thanks for the quick response on those queries.
On Friday 01 January 2010 04:58:36 Christian Hammond wrote:
> The documentation doesn't match because it covers 1.0.x, and you're
> running the 1.1 (soon 1.5) development branch.
I guessed this is the case. I was just a bit optimistic when I saw that
there was a manual for the "dev" version :-)
> You shouldn't have to add the scmtools by hand. Did you run the
> prepare-dev script? It should do it for you. If you did and it failed,
> run 'setup.py install' and then ./reviewboard/manage.py
> registerscmtools'
I did run the prepare-dev script, and it appeared to work (extract from
my original email below).
> On Thursday, December 31, 2009, bradh <br...@frogmouth.net> wrote:
> > I'm trying to follow the instructions at
> > http://www.reviewboard.org/docs/codebase/dev/getting-started/#gettingstar
> >ted and it looks like its mostly working. The prepare-dev.py script ends
> > with "Your Review Board tree is ready for development."
So I tried running "setup.py install" in the reviewboard checkout. It
appears that it can't find a suitable version of djblets, even after I
tried installing (again with "setup.py install") the git version.of djblets.
The "setup.py install" of reviewboard ends with:
Installed /usr/lib/python2.6/site-packages/ReviewBoard-1.1alpha3.dev-py2.6.egg
Processing dependencies for ReviewBoard==1.1alpha3.dev
Searching for Djblets>=0.5.7
Reading http://downloads.reviewboard.org/mirror/
Reading http://downloads.reviewboard.org/nightlies/
Reading http://pypi.python.org/simple/Djblets/
Reading http://www.review-board.org/wiki/Djblets
Reading http://downloads.review-board.org/releases/Djblets/0.5/
Reading http://downloads.review-board.org/releases/
No local packages or download links found for Djblets>=0.5.7
error: Could not find suitable distribution for Requirement.parse('Djblets>=0.5.7')
Brad
Brad Hards
> So I tried running "setup.py install" in the reviewboard checkout. It
> appears that it can't find a suitable version of djblets, even after I
> tried installing (again with "setup.py install") the git version.of
> djblets. The "setup.py install" of reviewboard ends with:
> No local packages or download links found for Djblets>=0.5.7
> error: Could not find suitable distribution for
> Requirement.parse('Djblets>=0.5.7')
I hacked around this by changing the the version information in the git
version of djblets and installing that.
I could then run "setup.py install" for reviewboard, and it installed OK.
I started the devserver, and logged into reviewboard. Still no SCM tools, but
I ran the "./reviewboard/manage.py registerscmtools" command and got back
lines that told me "New SCM Tool X (reviewboard.scmtools.x.XTool" for X in
Subversion, Git, Bazaar, CVS, Perforce, Clear Case and Mercurual.
Restarted the devserver, and I now see the various tools when I go to Add
Repository. I filled it in with
Name: OpenChange
Show this repository selected
Hosting service: Custom
Repository type: Subversion
Path: http://svn.openchange.org/openchange
Mirror path, Username, Password all empty
Use hosting service's bug tracker not selected
Type: None
Encoding left empty
When I press Save, I now get a message at the top of the screen (just under
"Add repository" and above "General Information") says:
[Icon of red circle with white hyphen] "Please correct the error below."
[Icon of yellow/orange triangle with white exclamation mark] "global name
'logging' is not defined"
Brad
Brad Hards
> "Add repository" and above "General Information") says:
> [Icon of red circle with white hyphen] "Please correct the error below."
> [Icon of yellow/orange triangle with white exclamation mark] "global name
> 'logging' is not defined"
diff --git a/reviewboard/scmtools/svn.py b/reviewboard/scmtools/svn.py
index 2d42247..843b101 100644
--- a/reviewboard/scmtools/svn.py
+++ b/reviewboard/scmtools/svn.py
@@ -1,3 +1,4 @@
+import logging
import re
import urllib
import urlparse
I can now create the Repository.
Brad