RB default reviewer group not getting updated
24 views
Skip to first unread message
manoj m
Oct 25, 2018, 6:16:35 PM10/25/18
to Review Board Community
Hello,
If an user uploads a new diff to an already published review request the default groups doesn't get updated. Is this expected?
On the contrary, an unpublished review requests gets updated properly.
Thanks
Christian Hammond
Oct 25, 2018, 7:45:38 PM10/25/18
to revie...@googlegroups.com
Hi,
This is expected. They only take effect for the initial review request. The idea is to prevent overriding the list of targeted reviewers, or to re-add someone who was removed, based on a re-run of the algorithm. Consider for instance an important confidential security fix that may initially trigger a Default Reviewer rule adding some people or groups to the list, but the owner of the review request erases them all and assigns it instead to a private "security" group. You wouldn't want anyone re-added if you were to update your change, for security disclosure reasons. Instead, once the review request is published, those fields are meant to be your responsibility to update.
This is expected. They only take effect for the initial review request. The idea is to prevent overriding the list of targeted reviewers, or to re-add someone who was removed, based on a re-run of the algorithm. Consider for instance an important confidential security fix that may initially trigger a Default Reviewer rule adding some people or groups to the list, but the owner of the review request erases them all and assigns it instead to a private "security" group. You wouldn't want anyone re-added if you were to update your change, for security disclosure reasons. Instead, once the review request is published, those fields are meant to be your responsibility to update.
Christian
--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
manoj
Oct 26, 2018, 5:05:29 PM10/26/18
to revie...@googlegroups.com
Makes sense, thanks for the quick reply.
You received this message because you are subscribed to a topic in the Google Groups "Review Board Community" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/vJATbjRVfJQ/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--Manoj Kumar M
manoj m
Nov 8, 2018, 12:54:11 PM11/8/18
to Review Board Community
Hello,
Is there a way to enable the "Default Reviewer" hook irrespective of review request state?
We don't use RB for any sensitive patches.
Reply all
Reply to author
Forward
0 new messages