Review entire file without a diff?

[Paulo Silva]

Hi,

Besides pre and post commit reviews I also have a use case for "ad-hoc reviews" where the team chooses a file and code reviews it (the last revision of it). 

In this case I don't want to use any diff file, I just want to pick the file and be able to review it.

How can I achieve this easily in reviewboard?

Basically I want to submit a file and review it all, without submiting a diff file. Is this possible? 

A possible hack would be to submit a diff file with the whole file lines? 

[Christian Hammond]

Hi Paulo,

Right now, your option is to submit a diff with that file as a new file. It'd then be reviewed just like any other diff. If it's going into the repository anyway, you might as well do that, since it'll be easy and familiar.

Going forward, we're working on better review support for file attachments, which will allow certain file types (text, images, code) to be reviewed. That'll make its first appearance in a 1.7 beta.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com

--
Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~----------~----~----~----~------~----~------~--~---
To unsubscribe from this group, send email to reviewboard...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en

[Paulo Silva]

ok, I understand.

Does anyone know how can I produce a diff file (CVS) with the file as a new file?

[scott.q...@gmail.com]

If the file is already in the repository, the just add a single space to the start of every line.

If it isn't in the repository, for cvs it is the the following two steps

Cvs add the file
Cvs diff -Nu

Scott

Sent wirelessly from my BlackBerry device on the Bell network.
Envoyé sans fil par mon terminal mobile BlackBerry sur le réseau de Bell.

---

From: Paulo Silva <alf...@gmail.com>

Sender: revie...@googlegroups.com

Date: Tue, 21 Aug 2012 11:48:34 -0700 (PDT)

To: <revie...@googlegroups.com>

ReplyTo: revie...@googlegroups.com

Cc: <chi...@chipx86.com>

Subject: Re: Review entire file without a diff?

[Paulo Silva]

ok, answering my own question:

cvs diff -uN -r 99999.99999999 <file>

Please note the  99999.99999999  that is a revision bigger than the current one of the file.

That seems to be produce a diff file as if the file is new. (don't ask me why :) )

Tested in windows client, CVS, CVSNT server.

Also using post-review with a revision range higher than the current one works.