Posting a new Review in 2.5.10

[Rob Backhurst]

Hi,

Since upgrading to RB 2.5.10 our developers have noticed they can not post a review without uploading a diff.

Previously, using the web interface you were able to create a RB form without a diff – Can we configure RB to allow this again? 

Thanks

Rob

[Christian Hammond]

Hi Rob,

This hasn't changed. You can still post review requests in the New Review Request page that don't require diffs by selecting "(None - File attachments only)" on the left. I just verified this on 2.5.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Rob Backhurst]

Hi Christian,

You'll have to excuse me, i do't use ReviewBoard myself so just relaying messages from our dev team.

----

When you do this then you are unable to add a diff at a later stage.

It creates the form as a non-repository form.

The workflow we sometimes use is:

1. Create form and fill in details using web browser.

2. From the server generate a diff and update the RB form

3. Reviewer add any comments they have to an email and then additionally attaches to the RB form.

We can create a non-repository form as you have seen, but when we then try and use a P4 changelist Id to generate a diff and attach to the form, it results in an error.

-----

Thanks

Rob

[Christian Hammond]

Hi Rob,

That's correct. The review request is only available for file attachments at that point. That's how it's been since Review Board 1.6. You can't create a review request for a repository without providing a diff.

If you have a diff, you can create a review request against the repository and attach the diff at that time, as before. The UI has just changed a bit. We strongly recommend using RBTools to create/update your review request, though, as this is simpler, faster, and works around bugs in Perforce diffs.

I'm confused about step #3, about the emails. Can you elaborate?

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.