Feature request for review board

[Pratyush Khan]

Hi review board community,

thank you for releasing the review board version 4.0.4, the multiple commit feature is very useful.

While using the multiple commit I felt need of following two features:

1.  Ability to add review comments against the commit log which are auto generated from git commit logs. From the "Reviews" , in the "Commits" section where list of commits are shown, I can only expand and see the commit log in Summary, but unable to add any comments if needed. If there is a way to add review comments against commit logs, that would be really helpful.

2. Ability to select a single commit to see its diff with a single mouse click. From the "Diffs", in "Commits" section where list of commits are shown along with option to select a range (First and Last) of commits, today if I need to see a diff of a specified commit, I'll need to click and select both of the associated radio buttons (i.e. First and Last) of that commit. But if there would be another one-click way, e.g. select another button associated with commit, using which it would open the diff from only that single commit, that should be really helpful.

thanks,

Pratyush

[Christian Hammond]

Hi Pratyush,

Thanks for the feature requests!

For #1, are you wanting to just leave a comment attached to that commit entry itself? Or to a line in the commit description? To help me understand how we might design it, can you give me some use cases?

For #2, we want to iterate on this UI a bit, bring a UI more similar to revision selection, but have had other priorities since 4.0 launched. It's on the roadmap, just not right away. I feel your pain on it though! I poke at updating it from time to time.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/0aa4b126-741c-4886-93f6-50e6320b3bb7n%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Pratyush Khan]

Hi Christian,

thanks for getting back. For #1, if we refer the reviews generated for git server, we can see that with version 4.0.4 and multi-commit support, multiple commit entries are shown under the "Commits" section with two columns (i.e. Summary and Author). Each auto populated commit entry can be expanded with a click on the little '+' icon. After the expansion, it basically shows the git commit log in read only mode. I'm looking for an option (as a new feature request) to select a portion of this expanded commit log text (by mouse click and drag) and add a review comment there. The review comments can be shown similar to the current review comments given on the diff.

thanks,

Pratyush