Cannot Fix/Drop/Re-open Issue in Safari browser (version 6.0.2)

[Becky Wong]

Hi,

In Safari, I'm unable to perform actions on the issues by clicking the 'Fixed', 'Drop' and 'Re-open' buttons. When I click the button, the buttons grey out (shown in screenshot below) but never complete.

Refreshing the page show no changes to the issue. I get the following errors in the developer tools console:

I'm using version 6.0.2, but I was also able to reproduce this on the demo review board instance too (at https://demo.reviewboard.org). Chrome and Firefox seem to work fine for me though. Is this something can be fixed for Safari?

Thanks,

Becky

[Christian Hammond]

Hi Becky,

Can you verify that your logged-in user (shown in the top-right) matches the owner of the review request?

Certainly it shouldn't show the buttons if you're not able to use it. There may be a bug here. However, you shouldn't be getting an HTTP 403 in this case.

We'll see if we can reproduce it on our end, but confirming the username above would help.

Also, are you running with any browser plugins?

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/73fd925b-6dc7-4792-a6a2-a87479588d6en%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Becky Wong]

Hi Christian,

I can confirm that the logged in user is also the owner of the review request. If I'm logged in as another user (that is not the owner), then the issue buttons do not show up.

This issue only happens in the Safari browser. I am able to successfully update the issue (mark as fixed, drop, or re-open) in the Chrome and Firefox browsers.

Steps to recreater:

1. Create a new review request
2. Add a comment (general or diff comment) with the 'Open an issue' checked
3. Click the 'Fixed' or 'Drop' button for the issue in a Safari browser. An error show up in the console and the issue update action gets stuck.

Selecting 'Fixed' or 'Drop' in a Chrome or Firefox browser worked without any issues for me.

I created a test review request in the demo instance, but it may get reset before you see it: https://demo.reviewboard.org/r/8/

Thanks,

Becky

[Shan Molvi]

Hello,

We are having the same problem with Reviewboard 7.0.2 in Safari but not in Firefox.

Checking the network requests, there is a critical difference between the request sent in Firefox and the request sent in Safari. In Firefox, when clicking “Fixed” on an issue, the form data sent in the request is: `api_format=json&issue_status=resolved`. In Safari, the same click results in only this form data: `api_format=json`. This behavior is reproducible every time.

I looked at the code to see if I find out why that `issue_status` parameter is being dropped, but I couldn’t figure it out. Hopefully this information helps to pinpoint exactly where the bug is.

The issue does not happen with the latest version of Safari, version 18. Specifically, “Version 18.0 (18619.1.26.111.10, 18619)” and "Version 18.0 (20619.1.26.31.6)” are fine. It does happen with “Version 17.6 (18618.3.11.11.7, 18618)”.

Shan

[Christian Hammond]

Thanks for the information! We’ve just managed to diagnose the root cause during this last week with another customer. It turns out to be a pretty serious bug in Safari itself.

We’ve verified that Safari 17.5 and 17.6 have a JavaScript execution bug where function parameters in async functions can end up becoming undefined, depending on usage within the function. We also verified they explicitly fixed and (vaguely) documented this in Safari 18 a few weeks ago, which is available for Ventura and higher.

We hit this bug due to logic involved in transpiling and then minifying our JavaScript code. We explored trying to work around this, but it’s brittle and we can’t guarantee that other code paths aren’t broken in other ways.

Given the severity of the bug within Safari, at this point we’re just recommending that people upgrade to Safari 18.

Christian

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/1c6531da-e9e0-4223-98cc-326524cbbeaen%40googlegroups.com.