Hi, I'd like to say that reviewboard is working great for me but I
have discovered some problems and missing features.
1) diff in post-review requires diff executable
I had to patch post-review to use diffutils instead of calling out to
"diff -urNp". On windows diff isn't part of the standard distribution
and I rather not force users to install it. Using diffutils as a drop
in replacement for the perforce client worked perfectly. I didn't test
with binaries though
2) ReviewBoard calls out to patch which only works under cygwin on
This isn't really a problem now on my test server but once we move it
to apache on windows, I wonder if this will become a problem
2) "View Diff" leads to a 404 if post hasn't been published yet.
This was extremely confusing because the user thought the review had
been published but maybe because of a user error, it wasn't clear to
me, the reviewer, that the review hadn't been properly published.
the user sent me the review, I clicked on it and then clicked on "View
Diffs" This lead to a 404 page instead (1) hidding the View diffs and
indicating that the review hadn't been published or (2) leading to a
page stating that the review hadn't been published yet. Once the user
properly published, then the diffs showed up correctly
3) Need support for either marking lines as defects/bugs or be able to
add severity levels to comments
Is there a standard way to do this now or is this another field that
needs to be added to the comments?
4) How can a user or admin mark that user as receiving all reviews?
One of our users wants to be able to see all reviews which are posted.
(He's the senior architect)
Is there a way to do this already?
5) Linking the django account with perforce
Currently, the users have to always authenticate with their
reviewboard username and password.
I'd like to have reviewboard use preforce to authenticate the user so
post-review doesn't need to always ask the user for the password.
6) Adding perforce triggers to prevent submission unless the review is
Has anyone tried doing this yet?
Thanks for the amazing work. I'll try to get approval to post my
patches to post-review eventually.
Speaking from my own experience with ReviewBoard, it doesn't always
work well when the working directory is being managed by multiple
Leo Soto M.