Interim "Show changes" for incremental diff review always shows complete list of files

[Pratyush Khan]

Hi RB community,

This is first time I've started using reviewboard with git. While trying to use the "rbt post" to send local commits to reviewboard server for review, I'm looking for how to do this for a series of commits (i.e. similar to patchset) properly.

If using "rbt post",  and there are multiple local commits, it only creates a giant diff of all the local commits and shows it in the review board server. But I can incrementally send the local commits to review board server using the command "rbt post -r <review id>", and it creates incremental diffs fine. Which kind of works creating a review consisting of a patchset.

However while doing this, every time "Review request changed" happens while uploading a new diff, the associated inline "Show changes" section always shows the complete list of changed files, instead of the incremental changed files. But clicking on the "Show changes" and opening the link works fine and show the correct diffs of interim revisions.

Can someone expert in review board please help and confirm if this is expected or not?

thanks,

Pratyush

[David Trowbridge]

Hi,

It sounds like you’re using a version of Review Board from before we added multi-commit support, and abusing the interdiff feature (which is intended to show changes between revisions of a code change) to instead show the changes between your commits.

What version of Review Board and RBTools do you have?

David

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/7859b373-b737-4d88-bb77-218561703d4dn%40googlegroups.com.

[Pratyush Khan]

Hi David,

thank you for responding to my query. I'm using RBTools 2.0.1 (Python 3.9.5) and using https://rbcommons.com/ for review board server. I'm not sure how to check the review board server's version in this case because it is hosted by https://rbcommons.com/

thanks,

Pratyush

[David Trowbridge]

Ahh, you're using RBCommons. Unfortunately that service is still based on Review Board 3.x, which does not have the multi-commit support. The good news is that we are in the final stages of moving it over to the newer version, and multi-commit review requests will be available within the next couple weeks.

David

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/f2aa8fea-8cb7-4718-bc98-6dab77ce782dn%40googlegroups.com.

[Pratyush Khan]

Thanks a lot David for clarifying this, will look forward to the multi-commit feature of review board.

thanks,

Pratyush