View diff is failing

11 views
Skip to first unread message

henriquecoelho

unread,
Jun 29, 2009, 7:33:32 PM6/29/09
to reviewboard
Hi all,

I'm having a problem viewing the diff file that i've upload in new
review request. I've activated the debug level for reviewboard and i'm
getting the following output when i access to view diff in right top
corner:

[Error 2] The system cannot find the file specified

Traceback (most recent call last):
File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\views.py", line 152, in view_diff
interdiffset, highlighting, True)
File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 623, in get_diff_files
large_data=True)
File "c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets
\util\misc.py", line 143, in cache_memoize
data = lookup_callable()
File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 622, in <lambda>
enable_syntax_highlighting),
File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 345, in get_chunks
new = get_patched_file(old, filediff)
File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 261, in get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
File "c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg
\reviewboard\diffviewer\diffutils.py", line 109, in patch
stderr=subprocess.STDOUT)
File "C:\Python25\Lib\subprocess.py", line 594, in __init__
errread, errwrite)
File "C:\Python25\Lib\subprocess.py", line 822, in _execute_child
startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

I'm not sure if this is sufficiently clear to you but if someone havy
an ideia about this please let me know how to workaround this. I think
that this could be due the problem with diff file so the steps that i
made to upload the new review diff file were:

-New review request
-choose the repository (example in my case)
-base diff path : /
-diff: c:\example\

The diff file:

Index: Apache2/conf/httpd.conf
===================================================================
--- Apache2/conf/httpd.conf (revision 3)
+++ Apache2/conf/httpd.conf (working copy)
@@ -467,4 +467,29 @@
AllowOverride All
</Directory>

+<<<<<<< .mine
+#<Location /moopion>
+# Order deny,allow
+# Allow from all
+#</Location>
+
+#Alias /moopion "C:\example\source\example\web"
+
+#<Directory "C:\example\source\example\web">
+# AllowOverride All
+#</Directory>
+
+<Location /sso>
+ Order deny,allow
+ Allow from all
+</Location>
+
+Alias /sso "C:\example\source\sso\webdir"
+
+<Directory "C:\example\source\sso\webdir">
+ AllowOverride All
+</Directory>
+
+=======
+>>>>>>> .r3
AllowEncodedSlashes On

Thanks in advance. Please if you need some specific further
information, let me know.

Christian Hammond

unread,
Jun 29, 2009, 7:37:07 PM6/29/09
to revie...@googlegroups.com
GNU patch.exe must be in the path for this to work. It appears that it's not able to find this.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com

henriquecoelho

unread,
Jun 29, 2009, 7:50:01 PM6/29/09
to reviewboard
Thanks for the quick review :)

In fact i had already the GNU patch.exe installed but not in the path.
I've set the C:\Program Files\GnuWin32\bin\ in the path and the
patch.exe is already defined in the environment vars, however the
error still appears. I'm using apache, so after set in environment the
previous path i've restarted the server but without success. Any other
suggestion?

On 30 Jun, 00:37, Christian Hammond <chip...@chipx86.com> wrote:
> GNU patch.exe must be in the path for this to work. It appears that it's not
> able to find this.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com

henriquecoelho

unread,
Jun 29, 2009, 7:52:10 PM6/29/09
to reviewboard
I should add that the diff file was generated with tortoisesvn,
creating a patch... Is there any known issue creating the diff in this
way?

On 30 Jun, 00:37, Christian Hammond <chip...@chipx86.com> wrote:
> GNU patch.exe must be in the path for this to work. It appears that it's not
> able to find this.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com

Christian Hammond

unread,
Jun 29, 2009, 8:20:02 PM6/29/09
to revie...@googlegroups.com
Yeah, TortoiseSVN definitely won't work. They generate slightly incompatible diffs. We might be able to work around it at some point, but someone would probably have to contribute a patch for that.

However, the "the system cannot find the file specified" error is definitely Apache not finding patch.exe.

Maybe try rebooting? :)

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com

Henrike Coelho

unread,
Jun 30, 2009, 6:32:22 PM6/30/09
to revie...@googlegroups.com
Hi Christian,

humm I've tried to do that, however without success :( the error still happens. patch-2.5.9-7-setup I've installed this version, do you know any issue with this version (python 2.5)? Can you give me an idea how can i generate diff files compatible with review board?
--
Cumprimentos

Henrike Coelho
mail:henrike...@gmail.com
     a40...@alunos.uminho.pt
site: http://hcc.wedevso.com
Universidade Minho

roman

unread,
Jul 2, 2009, 2:25:21 PM7/2/09
to reviewboard
Hi Guy,
Inspite of having the patch included in my path, I had to copy the
patch to the apache bin directory. This is not an elegant solutions,
but it works :).



On 30 jun, 19:32, Henrike Coelho <henrike.coe...@gmail.com> wrote:
> Hi Christian,
>
> humm I've tried to do that, however without success :( the error still
> happens. patch-2.5.9-7-setup I've installed this version, do you know any
> issue with this version (python 2.5)? Can you give me an idea how can i
> generate diff files compatible with review board?
>
> On Tue, Jun 30, 2009 at 1:20 AM, Christian Hammond <chip...@chipx86.com>wrote:
>
>
>
>
>
> > Yeah, TortoiseSVN definitely won't work. They generate slightly
> > incompatible diffs. We might be able to work around it at some point, but
> > someone would probably have to contribute a patch for that.
>
> > However, the "the system cannot find the file specified" error is
> > definitely Apache not finding patch.exe.
>
> > Maybe try rebooting? :)
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
>
> mail:henrike.coe...@gmail.com <mail%3Ahenrike.coe...@gmail.com>
>      a40...@alunos.uminho.pt
> site:http://hcc.wedevso.com
> Universidade Minho- Ocultar texto de la cita -
>
> - Mostrar texto de la cita -

roman

unread,
Jul 2, 2009, 2:08:15 PM7/2/09
to reviewboard
Hi All,
I'm having the same problme. patch.exe is included in the path but
the error is still there.
Any suggestions. Here is the stack trace:

Traceback (most recent call last):
File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1-
py2.5.egg\reviewboard\diffviewer\views.py", line 86, in view_diff
files = get_diff_files(diffset, None, interdiffset, highlighting)
File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1-
py2.5.egg\reviewboard\diffviewer\diffutils.py", line 660, in
get_diff_files
enable_syntax_highlighting)
File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1-
py2.5.egg\reviewboard\diffviewer\diffutils.py", line 579, in
generate_files
large_data=True)
File "c:\dev\python25\lib\site-packages\Djblets-0.5alpha1-py2.5.egg
\djblets\util\misc.py", line 142, in cache_memoize
data = lookup_callable()
File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1-
py2.5.egg\reviewboard\diffviewer\diffutils.py", line 578, in <lambda>
enable_syntax_highlighting),
File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1-
py2.5.egg\reviewboard\diffviewer\diffutils.py", line 340, in
get_chunks
new = get_patched_file(old, filediff)
File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1-
py2.5.egg\reviewboard\diffviewer\diffutils.py", line 256, in
get_patched_file
return patch(filediff.diff, buffer, filediff.dest_file)
File "c:\dev\python25\lib\site-packages\ReviewBoard-1.0alpha1-
py2.5.egg\reviewboard\diffviewer\diffutils.py", line 105, in patch
stderr=subprocess.STDOUT)
File "C:\dev\python25\Lib\subprocess.py", line 594, in __init__
errread, errwrite)
File "C:\dev\python25\Lib\subprocess.py", line 822, in
_execute_child
startupinfo)
WindowsError: [Error 2] The system cannot find the file specified


On 30 jun, 19:32, Henrike Coelho <henrike.coe...@gmail.com> wrote:
> Hi Christian,
>
> humm I've tried to do that, however without success :( the error still
> happens. patch-2.5.9-7-setup I've installed this version, do you know any
> issue with this version (python 2.5)? Can you give me an idea how can i
> generate diff files compatible with review board?
>
> On Tue, Jun 30, 2009 at 1:20 AM, Christian Hammond <chip...@chipx86.com>wrote:
>
>
>
>
>
> > Yeah, TortoiseSVN definitely won't work. They generate slightly
> > incompatible diffs. We might be able to work around it at some point, but
> > someone would probably have to contribute a patch for that.
>
> > However, the "the system cannot find the file specified" error is
> > definitely Apache not finding patch.exe.
>
> > Maybe try rebooting? :)
>
> > Christian
>
> > --
> > Christian Hammond - chip...@chipx86.com
> > Review Board -http://www.review-board.org
> > VMware, Inc. -http://www.vmware.com
>
> mail:henrike.coe...@gmail.com <mail%3Ahenrike.coe...@gmail.com>
>      a40...@alunos.uminho.pt
> site:http://hcc.wedevso.com

Henrike Coelho

unread,
Jul 2, 2009, 6:48:03 PM7/2/09
to revie...@googlegroups.com
Hi Roman, doesn't work for me.

-I've created a patch with tortoise svn and created a new review request
-I've moved the diff file to bin directory in apache folder (and restarted the server just in case)
-The same error still happens.

suggestions? I don't understand which is the really issue related with output...
mail:henrike...@gmail.com

Mario Roman

unread,
Jul 2, 2009, 6:51:44 PM7/2/09
to revie...@googlegroups.com
Hi Henrike,
  I've created the diff with Eclipse (team/create patch). Try that or with some another tool.

Bye.
--
Mario

Christian Hammond

unread,
Jul 3, 2009, 2:42:46 AM7/3/09
to revie...@googlegroups.com
Tortoise SVN doesn't generate compatible diffs. Try svn diff.

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.review-board.org
VMware, Inc. - http://www.vmware.com


Henrike Coelho

unread,
Jul 3, 2009, 9:01:19 AM7/3/09
to revie...@googlegroups.com
Humm, i made it :)

Basically the problem was the apache server not recognize the patch in the path. O i copied directly to the bin folder of apache and it started to work correclty.
And i tried generating the diff file with tortoise and it worked fine too...

Thanks guys for your help.
Reply all
Reply to author
Forward
0 new messages