Does Review Board support GitHub Pull Request?

[Nick Zheng]

Basically what we want is use Review Board as a pure code review tool. We want users to create the pull requests from GitHub, which will create a review request on Review Board. Any comments on Review Board will be reflected on GitHub. Is this supported currently?

Thanks,

Nick

[Christian Hammond]

Hi Nick,

No, it's not. The two are not directly compatible, and it would take some shoe-horning to mirror.

We've evaluated whether we can work with their API to properly mirror review requests and comments, but the models are different. For example, with Review Board, comments are grouped together under a single review, with general comments that appear before/after the list of diff comments, and comments may span multiple lines of code. Comments may also be added to arbitrary images, documents, text files, or anything else that's uploaded to Review Board, without having to commit them to a repository. There are no equivalents to these features in GitHub.

To support mirroring comments to GitHub, we'd basically have to reduce the feature set of Review Board.

We've found that most users who move to Review Board and away from pull requests are pretty happy with the result, as they're more flexible in how they create and update changes and where those changes come from, but that's completely dependent on the culture of the team.

The upcoming Review Board 2.0 release does allow you to easily create review requests based on individual commits on a branch on the central repository, but does not yet support ranges of commits or forks. We're looking into extending that, and also providing at least basic integration for creating based on pull requests, but that's a bit down the road (and wouldn't do comment mirroring).

Christian

--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org

Beanbag, Inc. - http://www.beanbaginc.com

--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Vinod Kone]

Any updates? Has anything changed or happened w.r.t GH PR integration with RB?

[Christian Hammond]

Hi Vinod,

This is in development for Review Board 4.0. It depends on the DVCS work being built in that release. We have a working prototype of the functionality needed to mirror pull requests to Review Board. However, due to the limitations in GitHub's pull requests, we won't be able to mirror comments back to GitHub.

Upon submitting a pull request, a corresponding review request will be created in Review Board, and a status will be opened against the pull request blocking it from landing and linking to the review request. Once the review request has been approved in Review Board (defaults to 1+ Ship Its and no open issues -- extensions can modify this logic) the status will be updated to allow the change to land.

3.0 isn't out yet, but these features have been built in parallel for 4.0 while 3.0 has been in development.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/

---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

[Vinod Kone]

Thanks for the update Christian. Really great to hear progress. What's the rough ETA for 4.0?

@vinodkone

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/gNpddxU9vnA/unsubscribe.
To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.

[Christian Hammond]

Not soon.

We're working to get 3.0 finished up and out the door. As soon as that's wrapped up, we're starting to focus on 4.0. It's not clear yet what all will be in 4.0, but the current plan (very much subject to change) is to smooth out the current DVCS support, build up some functionality around that, and get pull request support in for GitHub and Bitbucket (at a minimum).

We're probably looking at next year for this, unfortunately.

Now if you *really* need it sooner, it's completely possible to write an extension that provides a URL that GitHub can post to when a pull request has been created, and to take that diff, squash it, and place it in Review Board. If you wanted to represent each commit as a separate review request, that would also be doable, but a bit more work. We initially prototyped this against 3.0, but decided that this just wasn't going to be good enough (you really want multiple commits in one review request for this), which is why we're building it on 4.0 instead.

Christian

On Tue, Jun 6, 2017 at 11:54 PM, Vinod Kone <vino...@gmail.com> wrote:

Thanks for the update Christian. Really great to hear progress. What's the rough ETA for 4.0?

@vinodkone

On Jun 6, 2017, at 11:18 PM, Christian Hammond <chri...@beanbaginc.com> wrote:

Hi Vinod,

This is in development for Review Board 4.0. It depends on the DVCS work being built in that release. We have a working prototype of the functionality needed to mirror pull requests to Review Board. However, due to the limitations in GitHub's pull requests, we won't be able to mirror comments back to GitHub.

Upon submitting a pull request, a corresponding review request will be created in Review Board, and a status will be opened against the pull request blocking it from landing and linking to the review request. Once the review request has been approved in Review Board (defaults to 1+ Ship Its and no open issues -- extensions can modify this logic) the status will be updated to allow the change to land.

3.0 isn't out yet, but these features have been built in parallel for 4.0 while 3.0 has been in development.

Christian

On Tue, Jun 6, 2017 at 22:37 Vinod Kone <vino...@gmail.com> wrote:

Any updates? Has anything changed or happened w.r.t GH PR integration with RB?

On Wednesday, April 16, 2014 at 2:27:22 PM UTC-7, Nick Zheng wrote:

Basically what we want is use Review Board as a pure code review tool. We want users to create the pull requests from GitHub, which will create a review request on Review Board. Any comments on Review Board will be reflected on GitHub. Is this supported currently?

Thanks,

Nick

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/gNpddxU9vnA/unsubscribe.

To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

[Subodh Konhor]

Hi,

Just wanted to know or get confirmation is this feature now available in 4.0?

I see this particular information at https://www.reviewboard.org/integrations/github/

" We're working on integration with pull requests, to give you the convenience of pushing your code for review, but with Review Board's advanced review support."

What does " but with Review Board's advanced review support" mean? Is it a paid solution?

Thanks,

Subodh

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

--
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---

You received this message because you are subscribed to a topic in the Google Groups "reviewboard" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/gNpddxU9vnA/unsubscribe.

To unsubscribe from this group and all its topics, send an email to reviewboard...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

--

Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

[Christian Hammond]

Hi Subodh,

(We already talked about this separately, but following up for posterity.)

This feature is planned for a future Review Board release, but is not in 4.0. There are still some challenges to solve to make a seamless experience. We do plan for it to be in Review Board itself, rather than Power Pack, but we're still evaluating this.

The "advanced review support" covers features we offer that GitHub does not, such as comment issue tracking and verification, moved line detection, and interdiffs.

Christian

You received this message because you are subscribed to the Google Groups "Review Board Community" group.

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/6c725a58-e4a4-41cf-ab24-df18a5a73519n%40googlegroups.com.