Feature/plugin request: Add the ability to "Ship It" or "approve" a single file or section of code in a code review.

[Peter Kilner]

Hello,

Our group has seen a number of cases where poor code review result in bugs slipping though the code review process.  There are a number of reasons behind this.  One is, that a code reviews sometimes touches on so many different areas, which makes it impossible to find two reviewers that can give a thorough review of all the code in the code review.  

It would help if a review could give a “Ship it” to just the files (or lines of code) that they are experts on, rather than the entire CR.  Does review board have this functionality, or can this be added? Are there any plugin that add this functionality?  

Thank you,

Peter

[Christian Hammond]

Hi Peter,

It doesn't have this built-in, but the concept of approval is flexible. Extensions can mark changes as being approved, and if your repository's hooks are checking the approval state of the review request before letting the change in (or, client-side, if rbt land is being used), then changes will be blocked from landing if the custom approval logic doesn't allow it.

An extension could map files to groups and require that each group has a user that has given a Ship It before a change is approved to land. That'd be one option. Custom UI could also be added for marking that you've signed off on a file, though this would be a bit more extensive in terms of what the extension would need to do.

This also just depends on the types of changes being made there. We find that in an ideal situation, changes would be broken up by area of responsibility so that each team has a smaller piece of code to read, each of which would be able to land separately, pieced together by the Depends On field. This doesn't always work for all types of changes or products, though.

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board