Close & open triggers multiple issues

[webmas...@gmail.com]

I create two issues on a code review (1 generic and 1 on code-level). On my own instance https://reviews.melroy.org/r/2/.

When I try to close or open an specific issue. I noticed that my other issue is also getting closed or opened? When actually refreshing the website, it appears correct again.

Meaning the database action is correct. But the interactive javascript is showing it wrong. This is a bug in review board!

See video of what I mean:

[webmas...@gmail.com]

Ps. you can try to reproduce is locally. Or register an account on my server, you get by default added to the 'public' group. Where this specific review request is added to.

Op dinsdag 15 februari 2022 om 23:09:52 UTC+1 schreef webmas...@gmail.com:

[Christian Hammond]

That's bizarre. It does not reproduce locally.

Can you make that review request public, so I can inspect it?

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/a511c52a-f64a-4872-b19c-c303440b9247n%40googlegroups.com.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[webmas...@gmail.com]

You are right. I made it public now!

I hope you can see it now :)

Op donderdag 17 februari 2022 om 22:21:49 UTC+1 schreef Christian Hammond:

[webmas...@gmail.com]

Any update Christian?

Op zaterdag 26 februari 2022 om 18:03:44 UTC+1 schreef webmas...@gmail.com:

[Christian Hammond]

Hi,

My apologies. Most of our available support time has been directed to our paid support channel these days.

I found the cause of this. There's a bad check that got slipped in. Basically, each issue bar listens for issue status change events, and determines from those whether the bar should update. The IDs are compared directly, and IDs are namespaced by the comment type (in your case, a General Comment and a Diff Comment). The check isn't properly comparing the comment type in one circumstance.

We'll get a fix into 4.0.7. This is, fortunately, less likely to impact things in normal daily use (this is our first time seeing this) due to the fact that Diff Comments tend to be more common than other types, and there's rarely going to be overlap of IDs on the same review request.

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/0699d43f-8c3b-4af8-8e42-67e485157020n%40googlegroups.com.

[webmas...@gmail.com]

Thank you for solving this! I understand you focus more on paid support. But this bug is most likely impacting all customers.

Op zondag 6 maart 2022 om 10:39:35 UTC+1 schreef Christian Hammond:

[webmas...@gmail.com]

@Christian Hammond "We'll get a fix into 4.0.7."

It is actually not fixed at all in 4.0.7. Too bad.

The Review Board GUI still closes multiple issues at once. https://review.melroy.org/r/2/

Regards,

Melroy van den Berg

Op zondag 6 maart 2022 om 10:39:35 UTC+1 schreef Christian Hammond:

Hi,

[Christian Hammond]

Think I responded to this on another thread, but we have this fixed in 5.0 beta 1, and have a backport ready for 4.0.8 (which we're getting ready for release).

Christian

To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/3d9db164-9145-449f-bf92-e062fcda6a2bn%40googlegroups.com.