[P4] rbt post take the changelist as a path

900 views
Skip to first unread message

msc...@freejamgames.com

unread,
Aug 17, 2016, 6:16:16 AM8/17/16
to reviewboard
Hi all,

we got a weird problem while using rbt, we did a backup of the machine that host rbt and it changed some permission of the folders, now everything is as it was but when i try to use rbt post <changeset> (that always worked) it return me the error :

Path <Changeset> does not match a valid Perforce path.

the debug output say this:

>>> Running on Linux-4.4.0-34-generic-x86_64-with-Ubuntu-16.04-xenial
>>> Home = /home/path
>>> Current directory = /home/path/folder
>>> Checking for a Subversion repository...
>>> Unable to execute "svn help": skipping SVN
>>> Checking for a Git repository...
>>> Unable to execute "git --help" or "git.cmd --help": skipping Git
>>> Checking for a Mercurial repository...
>>> Unable to execute "hg --help": skipping Mercurial
>>> Checking for a CVS repository...
>>> Unable to execute "cvs": skipping CVS
>>> Checking for a Perforce repository...
>>> Running: p4 -c server info
>>> Running: diff --version
>>> repository info: Path: server:1666, Base path: None, Supports changesets: True
>>> Making HTTP GET request to http://localhost/api/
>>> Running: p4 -c server info
Path '31414' does not match a valid Perforce path.

from what i see the base path is null, so maybe the rbt is expecting that i pass it as an argument? This basepath is refer to my local perforce folder or the server root? How can i set it?

Many thanks,
Max 
 

Christian Hammond

unread,
Aug 17, 2016, 6:21:27 AM8/17/16
to revie...@googlegroups.com
Hi Max,

The "base path" is something that Subversion and Bazaar need, but not Perforce. You can safely ignore that.

Can you show me how you're running rbt post?

Christian

-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

msc...@freejamgames.com

unread,
Aug 17, 2016, 7:29:06 AM8/17/16
to reviewboard, chri...@beanbaginc.com
Hi Christian,

i was simply running rbt post --debug <changelist>, but i got the solution for this problem: simply, the changelist that i was using for creating a review was already submitted, IMHO the error message is not helpful at all and it should be rewrite for give to the user an hint of what it could be wrong, in this case i just lost 2 hours for googling/search for a solution to a non-existent problem.

Cheers,
Max
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

Christian Hammond

unread,
Aug 17, 2016, 5:04:41 PM8/17/16
to msc...@freejamgames.com, reviewboard
Hi Max,

I'm very sorry you lost time and productivity due to this. I know how that goes..

We have code that's supposed to be doing the right thing for submitted changesets. I don't know why it failed on your end. In fact, if the changeset was marked as submitted, you should have seen the log entry: "Generating diff for range of submitted changes".

I think what's happening is that the change number provided was found to be invalid for some reason, and this error internally was raised, but then swallowed unintentionally.

Can you let me know what versions of RBTools and Perforce you're using, and can you confirm that the changeset being referenced is owned by the same Perforce account that you'd see if creating a new changeset?

Is there a way you'd be able to share that changeset with me? (Filenames and description text could be masked)

Christian

-- 
Christian Hammond
President/CEO of Beanbag
Makers of Review Board

msc...@freejamgames.com

unread,
Aug 23, 2016, 8:00:03 AM8/23/16
to reviewboard, msc...@freejamgames.com, chri...@beanbaginc.com
Hi Christian,

sorry for the late reply, totally missed your last email.

the version of RBT is 0.7.6 and the perforce version is P4/LINUX26X86_64/2016.1/1404799. The account of Perforce that we use for creating the review was different from the owner of the changelist, this could be maybe a valid point why the correct error message was not raised, unluckly i cannot send you the files.  

Cheers,
Max
Reply all
Reply to author
Forward
0 new messages