Support for Perforce Task Stream in RB

[Tanvir Kazmi]

Hi,

I tried posting a review by specifying a Perforce changelist from a 'task stream' client. The review submission went fine, but the review did not load up the relevant file in the RB web interface, showing up an error as below. Can someone confirm if Perforce task streams are supported in Review Board?

rbt post for review happened fine as seen below.
/grid/common/pkgs/python/v2.7.2/bin/rbt post --target-people=lbansal --bugs-closed 1721498 -p 9065
Generating diff for pending changeset 9065
Review request #138799 posted.

However, when opening the diff online, it showed an error of the form:
http://reviewboard/reviews/r/138799/diff/1/

//avs/t_2027/nc_test/etc/C_Macros.hppa
There was an error displaying this diff.
The patch to '//avs/t_2027/nc_test/etc/C_Macros.hppa' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.mYtZ9l' for debugging purposes.
`patch` returned: 
This may be a bug in the software, a temporary outage, or an issue with the format of your diff.
Please try again, and if you still have trouble, contact support.

[Christian Hammond]

Hi Tanvir,

Can you confirm the version of p4python you have installed on the Review Board server? How recently was that installed?

Christian

--
Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups "reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Christian Hammond

President/CEO of Beanbag

Makers of Review Board

[Tanvir Kazmi]

Hi Christian,

I tried to figure out the p4python version using the following as advised on Perforce page for the same.

https://www.perforce.com/perforce/r16.2/user/p4pythonnotes.txt

	To display the version of P4Python you have installed,
	start Python and issue the following commands:

		>>> import P4
		>>> print(P4.P4.identify())

cmweb2: /home/tkazmi> /grid/common/pkgs/python/v2.7.2/bin/python

Python 2.7.2 (default, Mar 26 2013, 18:57:24)

[GCC 4.4.4 20100726 (Red Hat 4.4.4-13)] on linux2

Type "help", "copyright", "credits" or "license" for more information.

>>> import P4

Traceback (most recent call last):

  File "<stdin>", line 1, in <module>

ImportError: No module named P4

I am assuming we must be having some version of P4Python installed since we are able to post and view reviews just fine for non-task streams, but not sure which one. 

Can you recommend which version of P4Python should we move to? I guess it would be ok to stay with python 2.7.2 since it says it is compatible with P4Python 2010.1 or later.

Thanks,

Tanvir

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Christian Hammond]

Hi Tanvir,

Are you sure Review Board is being run under Python 2.7? Could it be under 2.6? I would expect the P4 import to work. Check the site-packages directories /usr/lib/python-2.6/site-packages and 2.7/site-packages/ to see if you can find P4* and ReviewBoard*

Christian

[Tanvir Kazmi]

Hi Christian,

I see the following on our Review Board website: Review Board 2.5.6.1

We do review board post by running: 

 /grid/common/pkgs/python/v2.7.2/bin/rbt post --target-people=lbansal --bugs-closed 1721498 -p 9380

So, the post call is done by executing python v2.7.2. We do have several versions of python installed on the network, but I check, rbt_post is found ONLY under v2.7.2 so I guess that's the python version, question is what's the P4Python version, if any being used.

On the machine where review board is running, I only see the following under /usr/lib:

/usr/lib/python2.4/

So, no later versions. So, I am confused. Does Review Board post absolutely need P4Python to run, or is it running in our setup without using that interface by making direct P4 calls?

Thanks,

Tanvir

[Christian Hammond]

Hi Tanvir,

The P4 module would be server-side, and the Perforce support 100% needs the P4 module. However, if the /grid/ is any indication, you have some non-default sort of packaging setup there, which I can't really help with much. You'd have to locate the path where the Review Board modules are being installed and look for the P4 there. You'd have to run Python under that environment. Someone at your company would know more about that, I'm sure.

Christian

To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Tanvir Kazmi]

Thanks, I was able to get this P4 module installed and verified by our in-house team.

However, it turned out, that was not the problem. The problem seems to be the fact that Perforce is unable to access any "just populated" task stream files across different geographies (different sites = difference Perforce proxies). Our Perforce server is based at one site, and I created a task stream and populated it on another site. Now, when I edited this in a task stream client and submitted it for review, the server side was unable to access the file and hence reports error. I found that even a p4 print of a file which was already populated on the task stream did not work!!!

p4 print //avs/t_tkazmi_test_task_1/vh_test/etc/C_Macros.wint#1

//avs/t_tkazmi_test_task_1/vh_test/etc/C_Macros.wint#1 - no such file(s).

See this image: http://imgur.com/a/DMxMC

The above file is definitely there, just not visible on the remote site, but visible on the site from where the task stream was created and populated.

The workaround was to do a dummy change submit first (which immediately resulted in file visibility across the 2nd remote site), or just do a post-commit review for a task stream. This may be a task stream specific Perforce issue and I am going to report it with their support.

Thanks for the help.

Tanvir